Skip to content

Conversation

@kernie
Copy link
Contributor

@kernie kernie commented Dec 14, 2021

Simple variable renaming to avoid warning about shadowed variable

Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

@kernie kernie requested a review from nlohmann as a code owner December 14, 2021 09:02
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 256473c on kernie:develop into 7603046 on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Dec 17, 2021
@nlohmann nlohmann added this to the Release 3.10.5 milestone Dec 17, 2021
@nlohmann nlohmann linked an issue Dec 17, 2021 that may be closed by this pull request
@nlohmann nlohmann merged commit 825d323 into nlohmann:develop Dec 17, 2021
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning for shadowed variables

3 participants