Updating the Homebrew Command

[amirmasoudabdol]

So, apparently, homebrew/core has a nlohmann-json formula. This means that, even after tapping to nlohmann/json, the user has to specify what formula should be used. and running brew install nlohmann-json will use the homebrew/core instead of the formula located at nlohmann/json. To resolve this, the install command needs to be more explicit and point to your formula.

You can point to your formula in two fashions, brew install nlohmann_json or more explicitly, brew install nlohmann/json/nlohmann_json. This distinguish it from the existing formula homebrew/core/nlohmann-json which I believe is not being maintained by people in this repo.

---

Pull request checklist

Read the Contribution Guidelines for detailed information.

• Changes are described in the pull request, or an existing issue is referenced.
• The test suite compiles and runs without error.
• Code coverage is 100%. Test cases can be added by editing the test suite.
• The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

• The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
• Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
• Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
• Please do not open pull requests that address multiple issues.

[coveralls]

Coverage remained the same at 100.0% when pulling 14af5d4 on amirmasoudabdol:patch-1 into f42a74b on nlohmann:develop.

[amirmasoudabdol]

I think this needs more attention. I just realised from some test that installing nlohmann_json from your nlohmann/json does not setup the CMake correctly. This might be because I had the version from homebrew/core installed and now it's being confused. But, I've tried a clean install and had the same problem.

As we discussed on Twitter, if you are willing to drop the nlohmann/json Formula, then we can make on the homebrew/core Formula and keep that updated. I try to update the homebrew formula for this update and reflect it on the README. However, we need to have this as part of the release checklist to make sure that it's been keeping up to date.

Update: I see. You formula has a --with-cmake flag. I don't recall this being like this either. I think the default was on CMake and I never have to think about. So, for the homebrew/core, I'm going to default on the CMake, as it is already actually.

Update: So, here is the updated Formula on homebrew/core. Let's see how this goes. If it goes well, we can default to the brew install nlohmann-json in the README file.

[amirmasoudabdol]

The PR at homebrew/core has been approved, and will be merged soon. So, I think this one can go after that one.

[nlohmann]

Can you please also adjust the documentation in https://github.com/nlohmann/json/blob/develop/doc/mkdocs/docs/integration/package_managers.md#homebrew ? Thanks!

[amirmasoudabdol]

I think that should be done!

[nlohmann]

Looks good to me.

[nlohmann]

Thanks!