Skip to content

Conversation

@JohanLorenzo
Copy link
Contributor

@JohanLorenzo JohanLorenzo commented Nov 20, 2025

Latest rationale.

image

Edit 2025-12-03: Color has changed from tan to turquoise.

@Archaeopteryx, r?

@JohanLorenzo JohanLorenzo force-pushed the unscheduled-tasks branch 2 times, most recently from 967c572 to 204fba1 Compare November 20, 2025 19:46
@JohanLorenzo JohanLorenzo marked this pull request as ready for review November 20, 2025 20:02
@JohanLorenzo JohanLorenzo requested a review from a team as a code owner November 20, 2025 20:02
Copy link
Collaborator

@Archaeopteryx Archaeopteryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohanLorenzo
Copy link
Contributor Author

Thank you for your review and the follow-up patches, @Archaeopteryx! I had to rebase my PR against master because of conflicts. I took the liberty of incorporating your commits into the PR (notably the one that changed the color to turquoise). I don't have the permission to merge the PR so I leave it to you, @Archaeopteryx.

@moijes12
Copy link
Contributor

@Archaeopteryx @JohanLorenzo

I am pretty new here so I may be wrong.
The code looks good. However, while going through the backend code, I did observe that we maintain the state in strings and repeat those strings every time we need to compare state or do any operation on it. Since the state is a set of predefined values ("pending", "running", "undefined" etc.), I would recommend that we use Enums or constant classes to store the state. This way we all operation will be performed keeping the enum in mind which might make the code more readable and reduce the change of any bug that might get introduced due to any typo in the string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants