Skip to content

feat: Try aws-lc-rs #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
larseggert wants to merge 10 commits into from
Closed

feat: Try aws-lc-rs #3084

larseggert wants to merge 10 commits into from

Conversation

@larseggert
Copy link
Collaborator

@larseggert larseggert commented Oct 27, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025 •
edited
Loading

🐰 Bencher Report

Branchfeat-awslc
TestbedOn-prem

🚨 2 Alerts

IterationBenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
2neqo vs. google (cubic, paced)Latency
milliseconds (ms)		📈 plot
🚷 threshold
🚨 alert (🔔)		777.87 ms
(+2.68%)Baseline: 757.53 ms
765.07 ms
(101.67%)

10quiche vs. neqo (cubic, paced)Latency
milliseconds (ms)		📈 plot
🚷 threshold
🚨 alert (🔔)		163.45 ms
(+6.79%)Baseline: 153.06 ms
158.85 ms
(102.90%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)		Upper Boundary
milliseconds (ms)
(Limit %)
google vs. neqo (cubic, paced)📈 view plot
🚷 view threshold		280.39 ms
(+0.97%)Baseline: 277.70 ms
280.40 ms
(99.99%)
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)		Upper Boundary
milliseconds (ms)
(Limit %)
msquic vs. neqo (cubic, paced)📈 view plot
🚷 view threshold		184.18 ms
(-6.38%)Baseline: 196.74 ms
233.70 ms
(78.81%)
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)		Upper Boundary
milliseconds (ms)
(Limit %)
neqo vs. google (cubic, paced)📈 view plot
🚷 view threshold
🚨 view alert (🔔)		777.87 ms
(+2.68%)Baseline: 757.53 ms
765.07 ms
(101.67%)

BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)		Upper Boundary
milliseconds (ms)
(Limit %)
neqo vs. msquic (cubic, paced)📈 view plot
🚷 view threshold		156.61 ms
(-0.68%)Baseline: 157.68 ms
160.70 ms
(97.45%)
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)		Upper Boundary
milliseconds (ms)
(Limit %)
neqo vs. neqo (cubic)📈 view plot
🚷 view threshold		88.37 ms
(-2.36%)Baseline: 90.50 ms
94.53 ms
(93.49%)
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)		Upper Boundary
milliseconds (ms)
(Limit %)
neqo vs. neqo (cubic, paced)📈 view plot
🚷 view threshold		89.34 ms
(-2.76%)Baseline: 91.88 ms
95.75 ms
(93.31%)
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)		Upper Boundary
milliseconds (ms)
(Limit %)
neqo vs. neqo (reno)📈 view plot
🚷 view threshold		86.19 ms
(-4.77%)Baseline: 90.51 ms
94.31 ms
(91.39%)
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)		Upper Boundary
milliseconds (ms)
(Limit %)
neqo vs. neqo (reno, paced)📈 view plot
🚷 view threshold		88.34 ms
(-3.79%)Baseline: 91.82 ms
95.69 ms
(92.31%)
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)		Upper Boundary
milliseconds (ms)
(Limit %)
neqo vs. quiche (cubic, paced)📈 view plot
🚷 view threshold		193.82 ms
(+0.06%)Baseline: 193.70 ms
197.10 ms
(98.34%)
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)		Upper Boundary
milliseconds (ms)
(Limit %)
neqo vs. s2n (cubic, paced)📈 view plot
🚷 view threshold		220.24 ms
(-0.28%)Baseline: 220.86 ms
223.66 ms
(98.47%)
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)		Upper Boundary
milliseconds (ms)
(Limit %)
quiche vs. neqo (cubic, paced)📈 view plot
🚷 view threshold
🚨 view alert (🔔)		163.45 ms
(+6.79%)Baseline: 153.06 ms
158.85 ms
(102.90%)

BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)		Upper Boundary
milliseconds (ms)
(Limit %)
s2n vs. neqo (cubic, paced)📈 view plot
🚷 view threshold		175.41 ms
(+0.70%)Baseline: 174.20 ms
178.32 ms
(98.37%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025 •
edited
Loading

🐰 Bencher Report

Branchfeat-awslc
TestbedOn-prem

🚨 1 Alert

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/clientLatency
milliseconds (ms)		📈 plot
🚷 threshold
🚨 alert (🔔)		38.64 ms
(+33.77%)Baseline: 28.89 ms
34.08 ms
(113.40%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client📈 view plot
🚷 view threshold		181,750,000.00 ns
(-12.23%)Baseline: 207,083,790.32 ns
218,305,562.90 ns
(83.25%)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client📈 view plot
🚷 view threshold		178,970,000.00 ns
(-11.01%)Baseline: 201,111,814.52 ns
213,064,266.42 ns
(84.00%)
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client📈 view plot
🚷 view threshold
🚨 view alert (🔔)		38,643,000.00 ns
(+33.77%)Baseline: 28,887,056.45 ns
34,077,743.55 ns
(113.40%)

1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client📈 view plot
🚷 view threshold		283,920,000.00 ns
(-2.90%)Baseline: 292,386,330.65 ns
305,742,342.57 ns
(92.86%)
1-streams/each-1000-bytes/simulated-time📈 view plot
🚷 view threshold		118,940,000.00 ns
(+0.35%)Baseline: 118,525,403.23 ns
120,834,754.60 ns
(98.43%)
1-streams/each-1000-bytes/wallclock-time📈 view plot
🚷 view threshold		555,150.00 ns
(-6.70%)Baseline: 594,990.60 ns
620,055.30 ns
(89.53%)
1000-streams/each-1-bytes/simulated-time📈 view plot
🚷 view threshold		15,000,000,000.00 ns
(+0.05%)Baseline: 14,992,854,838.71 ns
15,010,868,042.47 ns
(99.93%)
1000-streams/each-1-bytes/wallclock-time📈 view plot
🚷 view threshold		13,092,000.00 ns
(-6.97%)Baseline: 14,073,250.00 ns
14,930,957.88 ns
(87.68%)
1000-streams/each-1000-bytes/simulated-time📈 view plot
🚷 view threshold		19,035,000,000.00 ns
(+0.45%)Baseline: 18,949,052,419.35 ns
19,225,698,185.30 ns
(99.01%)
1000-streams/each-1000-bytes/wallclock-time📈 view plot
🚷 view threshold		43,779,000.00 ns
(-14.56%)Baseline: 51,236,927.42 ns
58,009,559.92 ns
(75.47%)
RxStreamOrderer::inbound_frame()📈 view plot
🚷 view threshold		109,480,000.00 ns
(-0.17%)Baseline: 109,663,467.74 ns
111,737,461.12 ns
(97.98%)
coalesce_acked_from_zero 1+1 entries📈 view plot
🚷 view threshold		88.39 ns
(-0.25%)Baseline: 88.60 ns
89.25 ns
(99.03%)
coalesce_acked_from_zero 10+1 entries📈 view plot
🚷 view threshold		106.08 ns
(+0.02%)Baseline: 106.06 ns
107.07 ns
(99.07%)
coalesce_acked_from_zero 1000+1 entries📈 view plot
🚷 view threshold		89.12 ns
(-0.75%)Baseline: 89.79 ns
94.10 ns
(94.71%)
coalesce_acked_from_zero 3+1 entries📈 view plot
🚷 view threshold		106.29 ns
(-0.25%)Baseline: 106.56 ns
107.55 ns
(98.83%)
decode 1048576 bytes, mask 3f📈 view plot
🚷 view threshold		1,757,700.00 ns
(+8.44%)Baseline: 1,620,876.61 ns
1,772,934.62 ns
(99.14%)
decode 1048576 bytes, mask 7f📈 view plot
🚷 view threshold		5,096,500.00 ns
(+0.63%)Baseline: 5,064,389.92 ns
5,105,625.31 ns
(99.82%)
decode 1048576 bytes, mask ff📈 view plot
🚷 view threshold		3,015,200.00 ns
(-0.47%)Baseline: 3,029,384.27 ns
3,046,937.36 ns
(98.96%)
decode 4096 bytes, mask 3f📈 view plot
🚷 view threshold		5,552.00 ns
(-29.30%)Baseline: 7,853.45 ns
10,216.55 ns
(54.34%)
decode 4096 bytes, mask 7f📈 view plot
🚷 view threshold		19,425.00 ns
(-2.44%)Baseline: 19,910.05 ns
20,433.51 ns
(95.06%)
decode 4096 bytes, mask ff📈 view plot
🚷 view threshold		10,617.00 ns
(-8.03%)Baseline: 11,544.47 ns
12,494.85 ns
(84.97%)
sent::Packets::take_ranges📈 view plot
🚷 view threshold		4,668.00 ns
(-1.56%)Baseline: 4,742.12 ns
4,977.14 ns
(93.79%)
transfer/pacing-false/same-seed/simulated-time/run📈 view plot
🚷 view threshold		25,710,000,000.00 ns
(+1.30%)Baseline: 25,381,097,560.98 ns
26,023,886,538.47 ns
(98.79%)
transfer/pacing-false/same-seed/wallclock-time/run📈 view plot
🚷 view threshold		21,883,000.00 ns
(-15.56%)Baseline: 25,914,174.80 ns
27,135,721.46 ns
(80.64%)
transfer/pacing-false/varying-seeds/simulated-time/run📈 view plot
🚷 view threshold		25,146,000,000.00 ns
(-0.10%)Baseline: 25,171,231,707.32 ns
25,219,261,890.04 ns
(99.71%)
transfer/pacing-false/varying-seeds/wallclock-time/run📈 view plot
🚷 view threshold		21,676,000.00 ns
(-16.69%)Baseline: 26,018,410.57 ns
27,625,070.50 ns
(78.46%)
transfer/pacing-true/same-seed/simulated-time/run📈 view plot
🚷 view threshold		25,675,000,000.00 ns
(+0.20%)Baseline: 25,623,719,512.20 ns
25,723,939,299.01 ns
(99.81%)
transfer/pacing-true/same-seed/wallclock-time/run📈 view plot
🚷 view threshold		22,903,000.00 ns
(-15.97%)Baseline: 27,255,398.37 ns
28,785,942.17 ns
(79.56%)
transfer/pacing-true/varying-seeds/simulated-time/run📈 view plot
🚷 view threshold		25,018,000,000.00 ns
(+0.10%)Baseline: 24,993,873,983.74 ns
25,043,580,728.72 ns
(99.90%)
transfer/pacing-true/varying-seeds/wallclock-time/run📈 view plot
🚷 view threshold		22,361,000.00 ns
(-15.71%)Baseline: 26,528,308.94 ns
28,194,329.63 ns
(79.31%)
🐰 View full continuous benchmarking report in Bencher

@larseggert larseggert mentioned this pull request Oct 28, 2025
Closed
larseggert added a commit to larseggert/neqo that referenced this pull request Oct 28, 2025
@larseggert
chore: Tweak cargo hack clippy call
d13f3aa 
Found as part of mozilla#3084. `--all-targets` also includes `build.rs`, which merges all, even incompatible, features. Also use `--no-dev-deps` as recommended at https://github.com/taiki-e/cargo-hack#--feature-powerset.
@larseggert larseggert mentioned this pull request Oct 28, 2025
Merged
@codecov
Copy link

codecov bot commented Oct 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.27848% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.97%. Comparing base (fb47282) to head (8ab0018).
⚠️ Report is 125 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
- Coverage   93.42%   92.97%   -0.45%     
==========================================
  Files         124      124              
  Lines       36045    35924     -121     
  Branches    36045    35924     -121     
==========================================
- Hits        33674    33401     -273     
- Misses       1525     1708     +183     
+ Partials      846      815      -31
Components Coverage Δ
neqo-common 97.24% <ø> (-0.13%) ⬇️
neqo-crypto 77.67% <82.27%> (-6.06%) ⬇️
neqo-http3 93.34% <ø> (ø)
neqo-qpack 94.18% <ø> (ø)
neqo-transport 94.39% <ø> (-0.10%) ⬇️
neqo-udp 78.94% <ø> (ø)
mtu 84.63% <ø> (-1.14%) ⬇️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to ab40a79.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Client/server transfer results

Performance differences relative to ab40a79.

Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.

Client vs. server (params) Mean ± σ Min Max MiB/s ± σ Δ main Δ main
google vs. google 478.3 ± 4.3 469.7 489.0 66.9 ± 7.4
google vs. neqo (cubic, paced) 280.4 ± 4.3 270.4 288.3 114.1 ± 7.4 -0.0 -0.0%
msquic vs. msquic 177.5 ± 55.4 136.5 382.9 180.2 ± 0.6
msquic vs. neqo (cubic, paced) 184.2 ± 54.0 141.4 442.9 173.7 ± 0.6 💚 -25.6 -12.2%
neqo vs. google (cubic, paced) 777.9 ± 3.2 772.6 790.3 41.1 ± 10.0 -0.0 -0.0%
neqo vs. msquic (cubic, paced) 156.6 ± 4.4 148.4 164.4 204.3 ± 7.3 💚 -2.0 -1.3%
neqo vs. neqo (cubic) 88.4 ± 4.9 78.4 98.6 362.1 ± 6.5 💚 -5.6 -5.9%
neqo vs. neqo (cubic, paced) 89.3 ± 6.1 81.0 113.7 358.2 ± 5.2 💚 -6.2 -6.5%
neqo vs. neqo (reno) 86.2 ± 4.3 78.3 103.0 371.3 ± 7.4 💚 -8.0 -8.5%
neqo vs. neqo (reno, paced) 88.3 ± 5.7 79.9 115.5 362.3 ± 5.6 💚 -5.9 -6.2%
neqo vs. quiche (cubic, paced) 193.8 ± 4.5 187.3 206.5 165.1 ± 7.1 -1.0 -0.5%
neqo vs. s2n (cubic, paced) 220.2 ± 4.1 212.6 231.3 145.3 ± 7.8 -0.1 -0.1%
quiche vs. neqo (cubic, paced) 163.5 ± 4.8 152.2 174.9 195.8 ± 6.7 💔 12.7 8.4%
quiche vs. quiche 142.8 ± 4.9 135.0 159.5 224.1 ± 6.5
s2n vs. neqo (cubic, paced) 175.4 ± 4.9 165.4 188.8 182.4 ± 6.5 1.1 0.6%
s2n vs. s2n 250.2 ± 23.7 231.5 347.7 127.9 ± 1.4

Download data for profiler.firefox.com or download performance comparison data.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Benchmark results

Performance differences relative to ab40a79.

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved.
       time:   [178.66 ms 178.97 ms 179.27 ms]
       thrpt:  [557.82 MiB/s 558.77 MiB/s 559.72 MiB/s]
change:
       time:   [−9.4391% −9.2131% −8.9886%] (p = 0.00 < 0.05)
       thrpt:  [+9.8763% +10.148% +10.423%]

Found 2 outliers among 100 measurements (2.00%)

1 (1.00%) low mild

1 (1.00%) high mild

1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: 💚 Performance has improved.
       time:   [281.81 ms 283.92 ms 286.10 ms]
       thrpt:  [34.953 Kelem/s 35.221 Kelem/s 35.485 Kelem/s]
change:
       time:   [−3.5156% −2.6486% −1.7302%] (p = 0.00 < 0.05)
       thrpt:  [+1.7607% +2.7207% +3.6436%]

Found 5 outliers among 100 measurements (5.00%)

1 (1.00%) low mild

4 (4.00%) high mild

1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.
       time:   [38.460 ms 38.643 ms 38.848 ms]
       thrpt:  [25.742   B/s 25.878   B/s 26.001   B/s]
change:
       time:   [−0.7225% −0.0777% +0.5529%] (p = 0.81 > 0.05)
       thrpt:  [−0.5498% +0.0777% +0.7277%]

Found 11 outliers among 100 measurements (11.00%)

1 (1.00%) low mild

2 (2.00%) high mild

8 (8.00%) high severe

1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: 💚 Performance has improved.
       time:   [181.46 ms 181.75 ms 182.05 ms]
       thrpt:  [549.29 MiB/s 550.22 MiB/s 551.10 MiB/s]
change:
       time:   [−11.971% −11.780% −11.590%] (p = 0.00 < 0.05)
       thrpt:  [+13.109% +13.353% +13.598%]

Found 2 outliers among 100 measurements (2.00%)

1 (1.00%) high mild

1 (1.00%) high severe

decode 4096 bytes, mask ff: Change within noise threshold.
       time:   [10.593 µs 10.617 µs 10.647 µs]
       change: [−1.0113% −0.5101% −0.0613%] (p = 0.03 < 0.05)

Found 8 outliers among 100 measurements (8.00%)

2 (2.00%) low severe

1 (1.00%) low mild

1 (1.00%) high mild

4 (4.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [3.0057 ms 3.0152 ms 3.0265 ms]
       change: [−0.9409% −0.2393% +0.3642%] (p = 0.52 > 0.05)

Found 10 outliers among 100 measurements (10.00%)

1 (1.00%) high mild

9 (9.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [19.369 µs 19.425 µs 19.487 µs]
       change: [−0.0075% +0.2917% +0.6164%] (p = 0.08 > 0.05)

Found 22 outliers among 100 measurements (22.00%)

3 (3.00%) low severe

5 (5.00%) low mild

2 (2.00%) high mild

12 (12.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [5.0851 ms 5.0965 ms 5.1094 ms]
       change: [−0.3758% −0.0252% +0.3137%] (p = 0.90 > 0.05)

Found 14 outliers among 100 measurements (14.00%)

14 (14.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [5.5249 µs 5.5520 µs 5.5850 µs]
       change: [−3.6308% −1.5133% +0.0154%] (p = 0.12 > 0.05)

Found 16 outliers among 100 measurements (16.00%)

8 (8.00%) low mild

1 (1.00%) high mild

7 (7.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.
       time:   [1.7575 ms 1.7577 ms 1.7578 ms]
       change: [−0.0264% −0.0119% +0.0012%] (p = 0.10 > 0.05)
1-streams/each-1000-bytes/wallclock-time: 💚 Performance has improved.
       time:   [552.88 µs 555.15 µs 557.88 µs]
       change: [−5.6024% −5.1221% −4.6216%] (p = 0.00 < 0.05)

Found 7 outliers among 100 measurements (7.00%)

7 (7.00%) high severe

1-streams/each-1000-bytes/simulated-time

time:   [118.73 ms 118.94 ms 119.14 ms]

thrpt:  [8.1965 KiB/s 8.2107 KiB/s 8.2248 KiB/s]

change:

time:   [−0.4793% −0.2278% +0.0285%] (p = 0.09 > 0.05)

thrpt:  [−0.0285% +0.2283% +0.4816%]

No change in performance detected.

1000-streams/each-1-bytes/wallclock-time: 💚 Performance has improved.
       time:   [13.069 ms 13.092 ms 13.116 ms]
       change: [−4.2705% −3.9262% −3.6232%] (p = 0.00 < 0.05)
1000-streams/each-1-bytes/simulated-time: No change in performance detected.
       time:   [14.987 s 15.000 s 15.012 s]
       thrpt:  [66.612   B/s 66.668   B/s 66.725   B/s]
change:
       time:   [−0.1470% −0.0335% +0.0918%] (p = 0.57 > 0.05)
       thrpt:  [−0.0917% +0.0336% +0.1472%]
1000-streams/each-1000-bytes/wallclock-time: 💚 Performance has improved.
       time:   [43.674 ms 43.779 ms 43.889 ms]
       change: [−9.8125% −9.4192% −9.0034%] (p = 0.00 < 0.05)

Found 8 outliers among 100 measurements (8.00%)

4 (4.00%) low mild

3 (3.00%) high mild

1 (1.00%) high severe

1000-streams/each-1000-bytes/simulated-time

time:   [18.923 s 19.035 s 19.147 s]

thrpt:  [51.003 KiB/s 51.304 KiB/s 51.607 KiB/s]

change:

time:   [−1.6988% −0.6401% +0.3960%] (p = 0.23 > 0.05)

thrpt:  [−0.3945% +0.6443% +1.7281%]

No change in performance detected.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [88.067 ns 88.387 ns 88.704 ns]
       change: [−0.6546% −0.0162% +0.7254%] (p = 0.96 > 0.05)

Found 10 outliers among 100 measurements (10.00%)

6 (6.00%) high mild

4 (4.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [105.93 ns 106.29 ns 106.67 ns]
       change: [−0.5187% −0.1651% +0.2041%] (p = 0.37 > 0.05)

Found 14 outliers among 100 measurements (14.00%)

1 (1.00%) low mild

13 (13.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [105.55 ns 106.08 ns 106.67 ns]
       change: [−0.2627% +0.1582% +0.6015%] (p = 0.48 > 0.05)

Found 14 outliers among 100 measurements (14.00%)

1 (1.00%) low mild

3 (3.00%) high mild

10 (10.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [88.995 ns 89.120 ns 89.280 ns]
       change: [−1.4807% −0.3144% +0.8082%] (p = 0.61 > 0.05)

Found 8 outliers among 100 measurements (8.00%)

3 (3.00%) high mild

5 (5.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [109.28 ms 109.48 ms 109.80 ms]
       change: [−0.4839% −0.2461% +0.0679%] (p = 0.07 > 0.05)

Found 2 outliers among 100 measurements (2.00%)

1 (1.00%) high mild

1 (1.00%) high severe

sent::Packets::take_ranges: No change in performance detected.
       time:   [4.5416 µs 4.6680 µs 4.7936 µs]
       change: [−3.9428% −0.5955% +2.6832%] (p = 0.74 > 0.05)

Found 2 outliers among 100 measurements (2.00%)

1 (1.00%) high mild

1 (1.00%) high severe

transfer/pacing-false/varying-seeds/wallclock-time/run: 💚 Performance has improved.
       time:   [21.650 ms 21.676 ms 21.702 ms]
       change: [−15.193% −14.974% −14.773%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)

1 (1.00%) high mild

transfer/pacing-false/varying-seeds/simulated-time/run: Change within noise threshold.
       time:   [25.111 s 25.146 s 25.182 s]
       thrpt:  [162.66 KiB/s 162.89 KiB/s 163.11 KiB/s]
change:
       time:   [−0.3999% −0.1991% −0.0156%] (p = 0.04 < 0.05)
       thrpt:  [+0.0156% +0.1995% +0.4015%]

Found 4 outliers among 100 measurements (4.00%)

1 (1.00%) low mild

3 (3.00%) high mild

transfer/pacing-true/varying-seeds/wallclock-time/run: 💚 Performance has improved.
       time:   [22.319 ms 22.361 ms 22.402 ms]
       change: [−14.329% −14.013% −13.714%] (p = 0.00 < 0.05)

Found 3 outliers among 100 measurements (3.00%)

3 (3.00%) high mild

transfer/pacing-true/varying-seeds/simulated-time/run: No change in performance detected.
       time:   [24.980 s 25.018 s 25.056 s]
       thrpt:  [163.48 KiB/s 163.72 KiB/s 163.97 KiB/s]
change:
       time:   [−0.1329% +0.0876% +0.3098%] (p = 0.44 > 0.05)
       thrpt:  [−0.3089% −0.0876% +0.1331%]
transfer/pacing-false/same-seed/wallclock-time/run: 💚 Performance has improved.
       time:   [21.870 ms 21.883 ms 21.897 ms]
       change: [−14.714% −14.632% −14.551%] (p = 0.00 < 0.05)

Found 5 outliers among 100 measurements (5.00%)

4 (4.00%) high mild

1 (1.00%) high severe

transfer/pacing-false/same-seed/simulated-time/run: No change in performance detected.
       time:   [25.710 s 25.710 s 25.710 s]
       thrpt:  [159.31 KiB/s 159.31 KiB/s 159.31 KiB/s]
change:
       time:   [+0.0000% +0.0000% +0.0000%] (p = NaN > 0.05)
       thrpt:  [+0.0000% +0.0000% +0.0000%]
transfer/pacing-true/same-seed/wallclock-time/run: 💚 Performance has improved.
       time:   [22.887 ms 22.903 ms 22.919 ms]
       change: [−13.066% −12.979% −12.894%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)

1 (1.00%) high mild

transfer/pacing-true/same-seed/simulated-time/run: No change in performance detected.
       time:   [25.675 s 25.675 s 25.675 s]
       thrpt:  [159.53 KiB/s 159.53 KiB/s 159.53 KiB/s]
change:
       time:   [+0.0000% +0.0000% +0.0000%] (p = NaN > 0.05)
       thrpt:  [+0.0000% +0.0000% +0.0000%]

Download data for profiler.firefox.com or download performance comparison data.

github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2025
@larseggert
chore: Tweak cargo hack clippy call (#3085)
67918df 
Found as part of #3084. `--all-targets` also includes `build.rs`, which merges all, even incompatible, features. Also use `--no-dev-deps` as recommended at https://github.com/taiki-e/cargo-hack#--feature-powerset.
@larseggert
Copy link
Collaborator Author

larseggert commented Dec 10, 2025

This was a useful exercise, but we were never going to go that route.

@larseggert larseggert closed this Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang will be requested when the pull request is marked ready for review KershawChang is a code owner

@martinthomson martinthomson Awaiting requested review from martinthomson martinthomson will be requested when the pull request is marked ready for review martinthomson is a code owner

@mxinden mxinden Awaiting requested review from mxinden mxinden will be requested when the pull request is marked ready for review mxinden is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@larseggert