Skip to content
This repository was archived by the owner on Dec 12, 2025. It is now read-only.

Conversation

@chatton
Copy link
Contributor

@chatton chatton commented Jun 23, 2020

All Submissions:

  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

This PR introduces functions used for the enterprise operator

@chatton chatton requested review from bznein and rodrigovalin June 23, 2020 15:49
Copy link
Contributor

@rodrigovalin rodrigovalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment on doing these reusable modules. We need to start adding proped godoc that can be formatted nicely using the godoc tooling. As a consequence of this, the docs for a given version could be released as part of our release process.

Great work on the functional approach.

🐺

@chatton
Copy link
Contributor Author

chatton commented Jun 24, 2020

@rodrigovalin great point about godoc, will update with this 👍

@chatton chatton merged commit 8100ed4 into master Jun 24, 2020
@chatton chatton deleted the add_functionality_for_enterprise branch June 24, 2020 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants