This repository was archived by the owner on Dec 12, 2025. It is now read-only.
CLOUDP-65697: Add init container and volumes to architecture doc #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rodrigovalin
left a comment
rodrigovalin
left a comment
There was a problem hiding this comment.
A few clarifications about the nature of the volumes mounted.
architecture.md
Outdated
| 1. Writes the Automation configuration as a [ConfigMap](https://kubernetes.io/docs/concepts/configuration/configmap/) and mounts it to each pod. | ||
| 1. Creates one [init container](https://kubernetes.io/docs/concepts/workloads/pods/init-containers/) and two [containers](https://kubernetes.io/docs/concepts/containers/overview/) in each pod: | ||
|
|
||
| - An init container which copies the `cmd/prestop` binary to the main `mongod` container. </br> |
Contributor
There was a problem hiding this comment.
what's the </br> doing here?
Contributor
Author
There was a problem hiding this comment.
There's a break for every item in the containers list since before. Should we remove that?
Contributor
There was a problem hiding this comment.
Can you check if it is necessary? if not needed, please remove 👍
Contributor
Author
There was a problem hiding this comment.
I think it's fine without them, removed.
architecture.md
Outdated
| 1. Creates several volumes: | ||
|
|
||
| - `data-volume` which is [persistent](https://kubernetes.io/docs/concepts/storage/persistent-volumes/) and mounts to `/data` on both the server and agent containers. Stores server data as well as `automation-mongod.conf` written by the agent and some locks the agent needs. | ||
| - `automation-config` which holds the mounted Automation config used by both the server and agent. |
Contributor
There was a problem hiding this comment.
maybe indicate that this is ephemeral storage (mounted from a configmap)?
architecture.md
Outdated
|
|
||
| - `data-volume` which is [persistent](https://kubernetes.io/docs/concepts/storage/persistent-volumes/) and mounts to `/data` on both the server and agent containers. Stores server data as well as `automation-mongod.conf` written by the agent and some locks the agent needs. | ||
| - `automation-config` which holds the mounted Automation config used by both the server and agent. | ||
| - `healthstatus` which contains the agent's current status. This is shared with the `mongod` container where it's used by the pre-stop hook. |
Contributor
There was a problem hiding this comment.
this is also ephemeral and lasts for as long as the Pod where it resides.
rodrigovalin
approved these changes
Jun 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).This PR adds a description of the pre-stop hook init container and the volumes to
architecture.md. There was a TODO comment for this.