-
Notifications
You must be signed in to change notification settings - Fork 19
Refreshing tickets, cutoff date, logging updates, bug fixes #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
config changes
haozturk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bug identified, changes needed
|
I think we need to think a bit more about the document viewing/uploader. One reason to keep the account creation central was to control who was given the ability to add/delete documents (like you mentioned is not handled now). In general, I can think of a few permutations in which you might want the viewer to be accessible to everyone or only some, and then the same with actual uploading permissions (deploying to admins vs users, for example). Is it a huge pain to move the account creation code to a different PR? Since ticket updating is more pressing, whereas the uploader is not, and can move this discussion/additional changes to the new PR? Let me know @juanpablosalas With respect to the updating of the tickets, thanks a lot for getting this done quick, it is definitely essential for the deployment! |
1a81925 to
0ee17ec
Compare
|
Thanks Juan, my biggest concern with the current way of refreshing tickets is that |
|
Getting the following error now @juanpablosalas Use |
|
There's a bug and a various points to improve @juanpablosalas . Let me know when they are addressed and I'll review again |
|
Thanks for the thorough feedback @haozturk , I pushed the changes |
This PR introduces a series of changes and bug fixes mainly to the handling of tickets.
Tickets
ChatWrapper. If the frequency is set to 0 it will pull the tickets again on every call. (See Refresh JIRA tickets since last pull #359)Logging
persistence.py,vectorstore/manager.py. A list of stored resources was being logged as info but I find this to make a lot of noise (specially considering there are hundreds of tickets in each project, not to mention the crawled pages). I reduced the logging level to DEBUG so it's not completely gone.httpxmoduleBug fixes/Code cleaning