Skip to content

Conversation

@juanpablosalas
Copy link
Collaborator

@juanpablosalas juanpablosalas commented Dec 6, 2025

This PR introduces a series of changes and bug fixes mainly to the handling of tickets.

Tickets

  • Introduces cutoff_date for JIRA and Redmine tickets. If specified, A2rchi will pull only tickets created before that date. One possible issue with this is that the ticket changes after the creation date will still be fetched. (See Introduce a cutoff date for JIRA #362)
  • Introduces frequency for JIRA and Redmine tickets. If specified, A2rchi will pull tickets updated/created since the last collection date within that frequency (in days). This update is triggered by a call to ChatWrapper. If the frequency is set to 0 it will pull the tickets again on every call. (See Refresh JIRA tickets since last pull #359)

Logging

  • Reduced logging in persistence.py, vectorstore/manager.py. A list of stored resources was being logged as info but I find this to make a lot of noise (specially considering there are hundreds of tickets in each project, not to mention the crawled pages). I reduced the logging level to DEBUG so it's not completely gone.
  • Reduced logging for httpx module

Bug fixes/Code cleaning

  • Deletes utils section from base config template as it has been superseded by sources
  • Removes outdated utils_config
  • Fixed circular import issues in document index and incorrect display of JIRA tickets

@juanpablosalas juanpablosalas changed the title Feature/refresh jira tickets Refreshing tickets, cutoff date, document index account creation, logging updates, bug fixes Dec 6, 2025
@juanpablosalas juanpablosalas marked this pull request as ready for review December 6, 2025 22:45
Copy link
Collaborator

@haozturk haozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bug identified, changes needed

@pmlugato
Copy link
Collaborator

pmlugato commented Dec 8, 2025

I think we need to think a bit more about the document viewing/uploader. One reason to keep the account creation central was to control who was given the ability to add/delete documents (like you mentioned is not handled now). In general, I can think of a few permutations in which you might want the viewer to be accessible to everyone or only some, and then the same with actual uploading permissions (deploying to admins vs users, for example).

Is it a huge pain to move the account creation code to a different PR? Since ticket updating is more pressing, whereas the uploader is not, and can move this discussion/additional changes to the new PR? Let me know @juanpablosalas

With respect to the updating of the tickets, thanks a lot for getting this done quick, it is definitely essential for the deployment!

@juanpablosalas juanpablosalas changed the title Refreshing tickets, cutoff date, document index account creation, logging updates, bug fixes Refreshing tickets, cutoff date, logging updates, bug fixes Dec 8, 2025
@juanpablosalas juanpablosalas force-pushed the feature/refresh_jira_tickets branch from 1a81925 to 0ee17ec Compare December 9, 2025 01:30
@juanpablosalas
Copy link
Collaborator Author

Hi @pmlugato, I agree with you! I think there are still some things we need to discuss regarding the document viewer so I switched those commits to #367

@haozturk
Copy link
Collaborator

haozturk commented Dec 9, 2025

Thanks Juan, my biggest concern with the current way of refreshing tickets is that update_tickets is a synchronous call which blocks the chat response until its termination. I think it's better to make it an async process that runs in the background. One way is to keep your implementation (trigger via chat call) and make it async or create a standalone service which periodically updates tickets. The second is a cleaner approach in my opinion and I don't know how much extra work it requires. What do you think? @juanpablosalas @pmlugato

@haozturk
Copy link
Collaborator

haozturk commented Dec 10, 2025

Getting the following error now @juanpablosalas

`(2025-12-10 11:10:23,531) [src.interfaces.chat_app.app] ERROR: Failed to update tickets - 'datetime.timedelta' object has no attribute 'minutes'`

Use .total_seconds() / 60 or seconds.
Also it'd be useful to add a debug logging line which tells if any ticket is updated, if so how many and so on.

@haozturk
Copy link
Collaborator

There's a bug and a various points to improve @juanpablosalas . Let me know when they are addressed and I'll review again

@juanpablosalas
Copy link
Collaborator Author

Thanks for the thorough feedback @haozturk , I pushed the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce a cutoff date for JIRA Refresh JIRA tickets since last pull handle accounts for document uploader and revisit obsolete secrets

4 participants