[BitSerializer] Update to v0.50 #28564
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JonLiu1993
added
the
category:port-update
ports/bitserializer/portfile.cmake
Outdated
| if (${BUILD_CSV_ARCHIVE}) | ||
| vcpkg_check_linkage(ONLY_STATIC_LIBRARY) | ||
| endif() |
There was a problem hiding this comment.
Flipping linkage by feature doesn't look right. If everything else is header-only, why use if at all?
There was a problem hiding this comment.
I was also doubt how will be right.
Thanks, fixed.
There was a problem hiding this comment.
On second sight, what's the problem with the CSV lib? If it is only DLL symbol export, dynamic linkage might work well for systems other than windows, and the statement might be wrapped into if(VCPKG_TARGET_IS_WINDOWS). This pattern exists in some other ports.
There was a problem hiding this comment.
In addition to export symbols on Windows, library doesn't have CMake code which support build shared library.
This is not big work, but as author, I don't see reasons to support shared linkage, the library is quite small.
If you know any cases where shared library will be useful even the library size is small, please let me know.
|
All features are tested successfully in the following triplet:
|
|
Tested usage successfully with |
JonLiu1993
added
the
info:needs-maintainer-attention
4 participants
Describe the pull request
What does your PR fix?
Updates BitSerializer to version 0.50
Which triplets are supported/not supported? Have you updated the CI baseline?
all (but only with static linkage),NoDoes your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes