[7-Zip] update to 22.01 #27995
Merged
[7-Zip] update to 22.01 #27995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
info:internal
category:port-update
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JonLiu1993
commented
Nov 24, 2022
| "name": "7zip", | ||
| "version": "22.0", | ||
| "port-version": 1, | ||
| "version-string": "22.01", |
Contributor
Author
There was a problem hiding this comment.
When I use the original "version", powershell tells me
error: while loading F:\Feature-test\v8\vcpkg\ports\7zip\vcpkg.json:
$ (a manifest): 'version' text was not a relaxed version:
error: `22.01` is not a valid relaxed version (semver with arbitrary numeric element count).
When I try to use "version-semver", I get the error again:
error: while loading F:\Feature-test\v8\vcpkg\ports\7zip\vcpkg.json:
$ (a manifest): 'version-semver' text was not a semantic version:
error: `22.01` is not a valid semantic version, consult
So in the end I chose "version-string"
Contributor
There was a problem hiding this comment.
Where is the problem with "versions": "22.1"?
vcpkg's unwillingness to handle leading zeros causes similar fuzziness for version-date in port poppler et al. Today, it also limits the usability of ${VERSION}.
MonicaLiu0311
approved these changes
Nov 25, 2022
MonicaLiu0311
added
the
info:needs-maintainer-attention
dg0yt
suggested changes
Nov 25, 2022
| "name": "7zip", | ||
| "version": "22.0", | ||
| "port-version": 1, | ||
| "version-string": "22.01", |
Contributor
There was a problem hiding this comment.
Where is the problem with "versions": "22.1"?
vcpkg's unwillingness to handle leading zeros causes similar fuzziness for version-date in port poppler et al. Today, it also limits the usability of ${VERSION}.
Contributor
|
Thank you! |
Contributor
|
IMO this PR needlessly degraded the version scheme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27993
Update 7zip to the latest version 22.01
Note: no feature need to test.