[7-Zip] update to 22.00 #25388
Merged
[7-Zip] update to 22.00 #25388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
info:internal
category:port-update
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Adela0814
reviewed
Jun 23, 2022
ports/7zip/vcpkg.json
Outdated
| "name": "7zip", | ||
| "version-string": "21.07", | ||
| "port-version": 1, | ||
| "version-string": "22.00", |
Contributor
There was a problem hiding this comment.
Should this be changed to version?
Contributor
Author
There was a problem hiding this comment.
@Adela0814, there should be "version-string", if we change it to "version" and then run the command "./vcpkg format-manifest ports/7zip/vcpkg.json" we get this error:
PS F:\Commit-pr\vcpkg> ./vcpkg format-manifest ports/7zip/vcpkg.json
Failed to parse manifest file: F:\Commit-pr\vcpkg\ports/7zip/vcpkg.json
Errors occurred while parsing F:\Commit-pr\vcpkg\ports/7zip/vcpkg.json
$ (a manifest): 'version' text was not a relaxed version:
Error: String `22.00` must only contain dot-separated numeric values without leading zeroes
Contributor
There was a problem hiding this comment.
version-string is bad for manifest mode. For now, simply drop leading zeros: "version": "22.0".
(There are more ports which live with this limitation, e.g. poppler.)
Adela0814
added
info:needs-maintainer-attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25338
Update 7-Zip to the latest version 22.00
Note: no feature need to test