List crashing tests #2357
Merged
List crashing tests #2357
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds tracking for crashing fourslash tests by creating a new crashingTests.txt file to complement the existing failingTests.txt. The script updateFailing.mts now detects tests that produce InternalError crashes and writes them to a separate list for better visibility.
Key Changes
- Added regex pattern to detect tests that crash with InternalError
- Created
crashingTests.txtto track 12 currently crashing tests - Updated
.gitignoreto include the new tracking file in version control
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/fourslash/_scripts/updateFailing.mts | Adds regex pattern and logic to detect and write crashing tests to crashingTests.txt |
| internal/fourslash/_scripts/crashingTests.txt | New file listing 12 tests that currently crash with InternalError |
| .gitignore | Adds exception to track crashingTests.txt in version control |
DanielRosenwasser
approved these changes
Dec 12, 2025
jakebailey
approved these changes
Dec 12, 2025
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Seems fine; this isn't more effort than maintaining the failing tests file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2350.
Not sure what the best way to surface this information is, but here's the list.