Tidy up some of our Velocity features #19605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few features were marked "always disabled" and then enabled in dev, canary and preview. I simplified those to "always enabled" and disabled in release instead. This required changes to Generate-FeatureStaging to make it consider `WindowsInbox` a Release branding (which, honestly, it always should have been.) - Feature_DynamicSSHProfiles - Feature_ShellCompletions - Feature_SaveSnippet - Feature_QuickFix Feature_DisableWebSourceIcons was deprecated in #19143, but the XML file never got the memo.
carlos-zamora
approved these changes
Dec 2, 2025
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Just the one question, but I'm not gonna block over it.
| # Then, branding type (if no overriding branch match) | ||
|
|
||
| If ($Branding -Eq "Release" -And $Feature.DisabledReleaseToken) { | ||
| If ($Branding -In @("Release", "WindowsInbox") -And $Feature.DisabledReleaseToken) { |
Member
There was a problem hiding this comment.
Double checking: no need to update https://github.com/microsoft/terminal/blob/main/doc/feature_flags.md right?
Member
Author
There was a problem hiding this comment.
eh. One can conceivably consider WindowsInbox a type of "Release"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few features were marked "always disabled" and then enabled in dev, canary and preview. I simplified those to "always enabled" and disabled in release instead. This required changes to Generate-FeatureStaging to make it consider
WindowsInboxa Release branding (which, honestly, it always should have been.)Feature_DynamicSSHProfiles had been improperly gating access to the SSH profile generator, which caused the build to fail when the feature was actually disabled after #19239.
Feature_DisableWebSourceIcons was deprecated in #19143, but the XML file never got the memo.