Fix a crash in _makeCursorVisible #19329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
reviewed
Sep 10, 2025
DHowett
reviewed
Sep 10, 2025
Co-authored-by: Dustin L. Howett <[email protected]>
DHowett
approved these changes
Sep 10, 2025
DHowett
reviewed
Sep 10, 2025
| { | ||
| ~SnapOnScopeExit() | ||
| { | ||
| if (self) |
Member
There was a problem hiding this comment.
oh wait. i can just return SnapOnOutput{nullptr} if the velocity feature is off. lol sorry.
Member
Author
There was a problem hiding this comment.
Oh true, I even had that in mind when I wrote that. 😅
DHowett
approved these changes
Sep 10, 2025
Member
|
now, does it actually fix 19325 :D |
DHowett
pushed a commit
that referenced
this pull request
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the crash and also makes
SnapOnOutputa bit nicer.Closes #19325
Validation Steps Performed