Fix right click on tabs closing them #19273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
Member
|
Marking this as "to consider" for cherry pick as it's too hot for 1.23 stable |
DHowett
reviewed
Sep 8, 2025
DHowett
reviewed
Sep 8, 2025
| // so when it calls ReleasePointerCapture() in its PointerReleased handler, | ||
| // we get a PointerCaptureLost before we receive the PointerReleased event. | ||
| // This makes typical handling of PointerReleased events on our side difficult. | ||
| // Well, whatever, now we just hook PointerCaptureLost because we know WinUI will trigger it. |
Member
There was a problem hiding this comment.
hm. is there a possible windows 10 vs 11 difference?
Member
Author
There was a problem hiding this comment.
No. I would prefer testing this in a follow-up if you don't mind.
DHowett
approved these changes
Sep 8, 2025
Co-authored-by: Dustin L. Howett <[email protected]>
DHowett
approved these changes
Sep 8, 2025
DHowett
pushed a commit
that referenced
this pull request
Sep 16, 2025
I do not like this. ## Validation Steps Performed * Enable close buttons on tabs * Open a tab * Close the tab with middle click * Open a tab * Right click the tab * Tab doesn't close, Menu opens ✅ (cherry picked from commit 4a34a76) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgeAlgM Service-Version: 1.24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not like this.
Validation Steps Performed