Skip to content

Fix SnapOnOutput not always snapping #19247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DHowett merged 1 commit into from
Aug 15, 2025
Merged

Fix SnapOnOutput not always snapping #19247

DHowett merged 1 commit into from
Aug 15, 2025

Conversation

@lhecker
Copy link
Member

@lhecker lhecker commented Aug 15, 2025

IsOn is the blinker on/off state, which IsVisible
is the actual cursor visibility on/off state.

Validation Steps Performed

  • Run bash/zsh in WSL
  • (Repeatedly) Quickly scroll right and press A-Z
  • Scrolls to the left ✅

@lhecker lhecker added Product-Conhost For issues in the Console codebase Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) labels Aug 15, 2025
@DHowett DHowett enabled auto-merge (squash) August 15, 2025 20:33
@DHowett DHowett merged commit e97388c into main Aug 15, 2025
17 of 19 checks passed
@DHowett DHowett deleted the dev/lhecker/18073-fixup branch August 15, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

Assignees

No one assigned

Labels

Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lhecker @DHowett