Manually focus panes after swapping them #19024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
pushed a commit
that referenced
this pull request
Jun 17, 2025
(cherry picked from commit bd7e317) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgbeR18 Service-Version: 1.22
DHowett
pushed a commit
that referenced
this pull request
Jun 17, 2025
(cherry picked from commit bd7e317) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgbeR2A Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes a bug where the swap panes action would result in no content being focused!
The root cause of this bug was that in
Pane::SwapPanes(), we would do the following:However,
_Focuswould exit early if the pane was_lastActive, which was always the case becauseGetActivePane()would retrieve the_lastActivepane!To fix this, we just manually focus the pane and its content.
Closes #18184
Validation Steps Performed