Skip to content

fix: don't print bidi isolates LRI, RLI, FSI, PDI #18942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DHowett merged 6 commits into from
May 30, 2025
Merged

fix: don't print bidi isolates LRI, RLI, FSI, PDI #18942

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
18f1e0d
fix: don't print bidi chars FSI and PDI
adalinesimonian May 23, 2025
5a9b861
fix: elide all dir. isolates from state machine
adalinesimonian May 24, 2025
ccc66a7
refactor: use char literals for isolates
adalinesimonian May 25, 2025
a2d7c17
fix: render isolates as zero-width spaces
adalinesimonian May 25, 2025
024276f
docs: adjust comment
adalinesimonian May 25, 2025
f2a148c
Use cmov, because the compiler can't
lhecker May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/renderer/atlas/AtlasEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,12 @@ try
{
for (const auto& ch : cluster.GetText())
{
// Skip Unicode FSI (U+2068) and PDI (U+2069).
// TODO: #538 - Remove this once we have proper support for bidirectional text.
if (ch == 0x2068u || ch == 0x2069u)
{
continue;
}
_api.bufferLine.emplace_back(ch);
_api.bufferLineColumn.emplace_back(columnEnd);
}
Expand Down
Loading