Allow multiple columns to be resized together

[seancolsen]

Fixes #4921

Related

• This replaces Fix: allow resizing multiple selected columns simultaneously (#4921) #5029

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the develop branch of the repository
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[pavish]

I'll say this, I like generators, however I find .map(...) more readable for usages like these.

[seancolsen]

Yeah, that's fair. Thinking back on this code, I think at some point I had been using some more logic inside that function, and then that changed. I don't recall exactly. I agree that in this case array mapping would be cleaner and more readable.

[pavish]

@seancolsen This works really well!

I added 58ce552 to exit early from columnsDatastore.setDisplayOptions when there are no entries, because batchRun (and batchSend) throw an error when there are no requests. This scenario happens when the user changes the width of a joined column.

The error from batchRun doesn't cause any problem, however, we ought to either remove that error or make the types more strict to avoid any uncaught exceptions.