[Xtensa] Add basic support for inline asm constraints. #108986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreisfr
requested review from
arsenm and
s-barannikov
and removed request for
s-barannikov
arsenm
reviewed
Sep 18, 2024
| %1 = load i32, i32* @gi | ||
| %2 = tail call i32 asm "addi $0, $1, $2", "=r,r,i"(i32 %a, i32 113) | ||
| ret i32 %2 | ||
| } |
Contributor
There was a problem hiding this comment.
Also test some cases with physical registers, and different types?
Contributor
Author
There was a problem hiding this comment.
Thank you for comments. I added more tests.
arsenm
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.