Skip to content

Clarify splicing feature flag requirements #4274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tankyleo wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Clarify splicing feature flag requirements #4274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lightning/src/ln/channelmanager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4854,6 +4854,12 @@ where
/// the channel. This will spend the channel's funding transaction output, effectively replacing
/// it with a new one.
///
/// # Required Feature Flags
///
/// Initiating a splice requires that the channel counterparty supports splicing. Any
/// channel (no matter the type) can be spliced, as long as a reconnection with the
/// counterparty occurred after they enabled splicing.
Comment on lines +4860 to +4861
Copy link
Collaborator

@TheBlueMatt TheBlueMatt Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// channel (no matter the type) can be spliced, as long as a reconnection with the
/// counterparty occurred after they enabled splicing.
/// channel (no matter the type) can be spliced, as long as the counterparty is currently
/// connected and supports splicing.

///
/// # Arguments
///
/// Provide a `contribution` to determine if value is spliced in or out. The splice initiator is
Expand Down