Do not overwrite custom CollectionInputFilter. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: illia <[email protected]>
Ocramius
requested changes
Jan 7, 2022
Member
Ocramius
left a comment
Ocramius
left a comment
There was a problem hiding this comment.
This kind of change requires test additions for validation and regression prevention
Signed-off-by: illia <[email protected]>
Ocramius
approved these changes
Jan 11, 2022
Member
Ocramius
left a comment
Ocramius
left a comment
There was a problem hiding this comment.
LGTM. Need someone else's review too, to see if this is the valid approach, but it is OK from my PoV.
Member
|
Also to be clarified: do we want this in |
weierophinney
approved these changes
Jan 11, 2022
Contributor
weierophinney
left a comment
weierophinney
left a comment
There was a problem hiding this comment.
This makes total sense to me.
Yes, it's a bugfix, but also a behavior change, so I'd argue we leave it for new minor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: illia [email protected]
This is a solution for issue #18 I posted last year. As there was no response so far I decided to create a pull request.