fix: policies file generation missing timeoutEvalSeconds. #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The marshalling funcion used to generate the policies file used by policy-server to load the policies is missing the recently added timeoutEvalSeconds field. Therefore, the policy-server is not enforcing the evaluation timeout for the policies. This commit fix the tests to guarantee that the function is working as expected and fix the MarshalJSON code as well. Signed-off-by: José Guilherme Vanz <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
- Coverage 73.27% 73.16% -0.12%
==========================================
Files 30 30
Lines 3944 3946 +2
==========================================
- Hits 2890 2887 -3
- Misses 890 894 +4
- Partials 164 165 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The marshalling funcion used to generate the policies file used by policy-server to load the policies is missing the recently added timeoutEvalSeconds field. Therefore, the policy-server is not enforcing the evaluation timeout for the policies. This commit fix the tests to guarantee that the function is working as expected and fix the MarshalJSON code as well.
Fix #1206
Test
make test