v1beta2: Delete .enable field from WaitForPodsReady API in config #7628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
cncf-cla: yes
mbobrovskyi
force-pushed
the
cleanup/delete-enable-field-from-WaitForPodsReady-API-in-config
branch
2 times, most recently
from
616b29d to
803b982
Compare
mbobrovskyi
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
mbobrovskyi
force-pushed
the
cleanup/delete-enable-field-from-WaitForPodsReady-API-in-config
branch
from
803b982 to
0d88784
Compare
Contributor
Author
|
/cc @mimowo |
k8s-ci-robot
added
the
needs-rebase
mbobrovskyi
force-pushed
the
cleanup/delete-enable-field-from-WaitForPodsReady-API-in-config
branch
from
0d88784 to
40e7c62
Compare
k8s-ci-robot
removed
the
needs-rebase
mbobrovskyi
force-pushed
the
cleanup/delete-enable-field-from-WaitForPodsReady-API-in-config
branch
from
40e7c62 to
2b61db3
Compare
Contributor
|
please rebase |
mimowo
reviewed
Nov 14, 2025
| if cfg.WaitForPodsReady != nil { | ||
| cfg.WaitForPodsReady.Timeout = cmp.Or(cfg.WaitForPodsReady.Timeout, &metav1.Duration{Duration: defaultPodsReadyTimeout}) | ||
| cfg.WaitForPodsReady.BlockAdmission = cmp.Or(cfg.WaitForPodsReady.BlockAdmission, &cfg.WaitForPodsReady.Enable) | ||
| cfg.WaitForPodsReady.BlockAdmission = cmp.Or(cfg.WaitForPodsReady.BlockAdmission, ptr.To(true)) |
Contributor
There was a problem hiding this comment.
Actually, I think we should change the default to "false" as part of v1beta2. This is much more commonly used setting.
Let me open: #7656
mbobrovskyi
force-pushed
the
cleanup/delete-enable-field-from-WaitForPodsReady-API-in-config
branch
from
2b61db3 to
365b88a
Compare
mbobrovskyi
force-pushed
the
cleanup/delete-enable-field-from-WaitForPodsReady-API-in-config
branch
from
365b88a to
6d3142a
Compare
Contributor
Author
|
/retest Due to known issue #7457. |
Contributor
Author
Done |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 60cb6971c8192d2524fe9fb78312b9b3761b444f
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mbobrovskyi
deleted the
cleanup/delete-enable-field-from-WaitForPodsReady-API-in-config
branch
tenzen-y
reviewed
Nov 14, 2025
Comment on lines
215
to
217
| // WaitForPodsReady defines configuration for the Wait For Pods Ready feature, | ||
| // which is used to ensure that all Pods are ready within the specified time. | ||
| type WaitForPodsReady struct { |
Member
There was a problem hiding this comment.
If users want to enable w/ default parameters, how to specify that?
@mimowo @mbobrovskyi Do you assume the following one?
waitForPodsReady: {}I am slightly histatin this way since It looks weird.
Contributor
Author
Member
There was a problem hiding this comment.
I think so too, let me mention this in issue.
Singularity23x0
pushed a commit
to Singularity23x0/kueue
that referenced
this pull request
Nov 17, 2025
tenzen-y
reviewed
Nov 27, 2025
| managerConfig: | ||
| controllerManagerConfigYaml: |- | ||
| apiVersion: config.kueue.x-k8s.io/v1beta2 | ||
| apiVersion: config.kueue.x-k8s.io/v1beta1 |
Contributor
Author
There was a problem hiding this comment.
Just for test. To make sure that we can use it with v1beta1.
Member
There was a problem hiding this comment.
SGTM, thank you for describing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind api-change
What this PR does / why we need it:
v1beta2: Delete .enable field from WaitForPodsReady API in config
Which issue(s) this PR fixes:
Fixes #7584
Special notes for your reviewer:
Does this PR introduce a user-facing change?