Skip to content

Improved RayJob Logic - bugfix on Lifecycled RayJobs causing Webhook … #7258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Oct 14, 2025
Merged

Improved RayJob Logic - bugfix on Lifecycled RayJobs causing Webhook … #7258

k8s-ci-robot merged 1 commit into from
Oct 14, 2025

Conversation

@laurafitzgerald
Copy link
Contributor

@laurafitzgerald laurafitzgerald commented Oct 14, 2025 •
edited
Loading

This is an manual cherry-pick of #7218

@mimowo

/release-note-edit

Fix handling of RayJobs which specify the spec.clusterSelector and the "queue-name" label for Kueue. These jobs should be ignored by kueue as they are being submitted to a RayCluster which is where the resources are being used and was likely already admitted by kueue. No need to double admit.
Fix on a panic on kueue managed jobs if spec.rayClusterSpec wasn't specified.

@k8s-ci-robot k8s-ci-robot added this to the v0.14 milestone Oct 14, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 14, 2025
@netlify
Copy link

netlify bot commented Oct 14, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit c265095
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68ee0d49db8cc3000838d5aa

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 14, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 14, 2025

Hi @laurafitzgerald. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 14, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 14, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 14, 2025

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 14, 2025
@laurafitzgerald
Improved RayJob Logic - bugfix on Lifecycled RayJobs causing Webhook …
c265095 
…to panic

len(spec.ClusterSelector)>0 && spec.RayClusterSpec != nil -> validation error
len(spec.ClusterSelector)>0 && spec.RayClusterSpec == nil - valid
len(spec.ClusterSelector)==0 && spec.ClusterSpec == nil -> validation error
len(spec.ClusterSelector)==0 && spec.ClusterSpec != nil -> valid + perform additional validation
@laurafitzgerald laurafitzgerald force-pushed the manual-cherry-pick-7218-to-release-0.14 branch from b04be4d to c265095 Compare October 14, 2025 08:43
@mimowo
Copy link
Contributor

mimowo commented Oct 14, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 14, 2025

LGTM label has been added.

Git tree hash: 2e694280d8636072d8b6ec3499f26e6fea713b4a

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laurafitzgerald, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4cd960d into kubernetes-sigs:release-0.14 Oct 14, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannon92 kannon92 Awaiting requested review from kannon92

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

Assignees

@mimowo mimowo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.14

Development

Successfully merging this pull request may close these issues.

3 participants

@laurafitzgerald @k8s-ci-robot @mimowo