-
Notifications
You must be signed in to change notification settings - Fork 6.8k
cilium: add configurable Helm chart repository #12709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GmrezaH The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @GmrezaH. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The same can be achieved, without a code change, defining: cilium_install_extra_flags: "--repository {{ files_repo }}/helm.cilium.io/" |
|
@GmrezaH is the solution above working for you ? |
|
/ok-to-test |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for specifying a custom Helm chart repository when installing Cilium through Kubespray.
Currently, Kubespray installs Cilium using the default upstream Helm chart location, which is not suitable for air-gapped or restricted environments.
This change introduces a new variable,
cilium_chart_repository_url, and adds the corresponding --repository flag to the Cilium install/upgrade task.This allows users to:
Mirror the Cilium chart internally for offline deployments
Retain the existing Cilium installation workflow, including Kubespray’s pre-flight and post-flight checks
Avoid switching to custom_cni, which lacks Cilium-specific checks
The default behavior remains unchanged for users who do not set the variable.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The new variable is optional and defaults to the cilium upstream chart repository.
Behavior is fully backward compatible.
This aligns Cilium with how other CNIs can reference custom chart repositories while keeping Cilium’s enhanced validation tasks.
Does this PR introduce a user-facing change?: