Add support for hubble-export-file-max-backups and max-size-mb variables #12072

ErmolenkoMaxim · 2025-03-24T14:27:14Z

/kind feature

What this PR does / why we need it:
Adds support for configuring additional Hubble file export parameters in the Cilium ConfigMap via Kubespray inventory:

hubble-export-file-max-backups
hubble-export-file-max-size-mb

These variables are useful for controlling the size and rotation of flow logs when using file-based export in Hubble. They were previously not configurable from Kubespray and had to be set manually.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

These values are only added to the Cilium ConfigMap if the inventory variables are explicitly defined.
This avoids overriding Cilium’s default behavior unintentionally.

Does this PR introduce a user-facing change?:

Users can now configure `hubble-export-file-max-backups` and `hubble-export-file-max-size-mb` through the Kubespray inventory.

k8s-ci-robot · 2025-03-24T14:27:23Z

Hi @ErmolenkoMaxim. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ant31 · 2025-03-25T11:32:58Z

/ok-to-test
/label ci-short

roles/network_plugin/cilium/defaults/main.yml

roles/network_plugin/cilium/templates/cilium/config.yml.j2

ErmolenkoMaxim · 2025-03-28T11:59:47Z

@ant31 Hello, both files modified, please check.

ant31 · 2025-03-29T17:15:01Z

it's expected to be a string ?

you must rebase master to for the ci the pass
/lgtm

ErmolenkoMaxim · 2025-04-02T06:08:25Z

rebased

ErmolenkoMaxim · 2025-04-07T06:56:00Z

@mzaian
@cyclinder
guys please check

ant31 · 2025-04-09T07:35:15Z

/lgtm

VannTen · 2025-04-24T08:09:39Z

You should have the actual default values in the defaults/ folder.

This is turn allow to eschew the defined tests and simply use the variable which is guaranteed to be there.

ErmolenkoMaxim · 2025-04-24T09:14:12Z

You should have the actual default values in the defaults/ folder.

This is turn allow to eschew the defined tests and simply use the variable which is guaranteed to be there.

roles/kubespray-defaults/tasks/main.yaml <--- here? @VannTen

roles/network_plugin/cilium/defaults/main.yml

VannTen · 2025-04-25T09:07:32Z

Please squash your changes into 1 commit with a descriptive message. (in particular, not referring to the PR discussion but only to the changes themselves)

- Adds support for `cilium_hubble_export_file_max_backups` and `cilium_hubble_export_file_max_size_mb` - Applies values only if `cilium_hubble_export_file_path` is defined - Default values are set in role defaults - Cleans up template logic by removing unnecessary conditionals

ErmolenkoMaxim · 2025-04-30T08:32:26Z

@VannTen please check.
Error: You do not have permission to create labels on this repository.: {"resource":"Repository","field":"label","code":"unauthorized"} - https://docs.github.com/v3/issues/labels/

roles/network_plugin/cilium/templates/cilium/config.yml.j2

…caused pre-commit errors

rollback

VannTen · 2025-05-17T07:32:12Z

/lgtm /approve Thanks 👍

k8s-ci-robot · 2025-05-17T07:32:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ErmolenkoMaxim, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [VannTen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 24, 2025

k8s-ci-robot requested review from cyclinder and mzaian March 24, 2025 14:27

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. ci-short Run a quick CI pipeline and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 25, 2025

ant31 reviewed Mar 25, 2025

View reviewed changes

roles/network_plugin/cilium/defaults/main.yml Outdated Show resolved Hide resolved

ant31 reviewed Mar 25, 2025

View reviewed changes

roles/network_plugin/cilium/templates/cilium/config.yml.j2 Outdated Show resolved Hide resolved

ant31 reviewed Mar 25, 2025

View reviewed changes

roles/network_plugin/cilium/templates/cilium/config.yml.j2 Outdated Show resolved Hide resolved

k8s-ci-robot assigned ant31 Mar 29, 2025

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 29, 2025

ErmolenkoMaxim force-pushed the feature/hubble-export-vars branch from 49d22bf to 085f714 Compare April 2, 2025 06:07

VannTen reviewed Apr 24, 2025

View reviewed changes

roles/network_plugin/cilium/defaults/main.yml Outdated Show resolved Hide resolved

ErmolenkoMaxim force-pushed the feature/hubble-export-vars branch from 1091a11 to 73df2da Compare April 25, 2025 07:12

ErmolenkoMaxim force-pushed the feature/hubble-export-vars branch from a606e0b to 1909c6a Compare April 25, 2025 07:40

k8s-ci-robot removed the do-not-merge/contains-merge-commits label Apr 25, 2025

ErmolenkoMaxim force-pushed the feature/hubble-export-vars branch from 1909c6a to bbe8842 Compare April 25, 2025 08:25

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 25, 2025

ErmolenkoMaxim requested review from VannTen and ant31 April 25, 2025 08:49

ErmolenkoMaxim force-pushed the feature/hubble-export-vars branch from bbe8842 to 6f2c5e3 Compare April 25, 2025 09:22

VannTen reviewed May 2, 2025

View reviewed changes

roles/network_plugin/cilium/templates/cilium/config.yml.j2 Outdated Show resolved Hide resolved

Fix indentation for hubble export settings

2fff4e4

ErmolenkoMaxim force-pushed the feature/hubble-export-vars branch from 92d0a8b to 2fff4e4 Compare May 6, 2025 08:41

ErmolenkoMaxim and others added 2 commits May 6, 2025 11:57

Fix undefined variable issue with ipwrap in kubeconfig override that …

d0afd06

…caused pre-commit errors

Update main.yml

e136063

rollback

ErmolenkoMaxim requested a review from VannTen May 7, 2025 09:22

tico88612 mentioned this pull request May 10, 2025

Refactor Cilium CNI installation #12101

Merged

k8s-ci-robot assigned VannTen May 17, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2025

k8s-ci-robot merged commit 46a0dc9 into kubernetes-sigs:master May 17, 2025
27 checks passed

tico88612 mentioned this pull request May 20, 2025

Release Proposal v2.28.0 #12175

Closed

Add support for hubble-export-file-max-backups and max-size-mb variables #12072

Add support for hubble-export-file-max-backups and max-size-mb variables #12072

Uh oh!

Conversation

ErmolenkoMaxim commented Mar 24, 2025 • edited by ant31 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 24, 2025

Uh oh!

ant31 commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ErmolenkoMaxim commented Mar 28, 2025

Uh oh!

ant31 commented Mar 29, 2025

Uh oh!

ErmolenkoMaxim commented Apr 2, 2025

Uh oh!

ErmolenkoMaxim commented Apr 7, 2025

Uh oh!

ant31 commented Apr 9, 2025

Uh oh!

VannTen commented Apr 24, 2025

Uh oh!

ErmolenkoMaxim commented Apr 24, 2025

Uh oh!

Uh oh!

VannTen commented Apr 25, 2025 via email

Uh oh!

ErmolenkoMaxim commented Apr 30, 2025

Uh oh!

Uh oh!

VannTen commented May 17, 2025 via email

Uh oh!

k8s-ci-robot commented May 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ErmolenkoMaxim commented Mar 24, 2025 •

edited by ant31

Loading