Skip to content

Conversation

@mboersma
Copy link
Contributor

@mboersma mboersma commented Dec 4, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Moves the default k8s version forward from 1.32 to 1.33 to avoid falling into the unsupported version trap, as has happened before.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
See #5528 for prior art.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 4, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.72%. Comparing base (e2db814) to head (d776dfe).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5994   +/-   ##
=======================================
  Coverage   44.72%   44.72%           
=======================================
  Files         279      279           
  Lines       25274    25274           
=======================================
  Hits        11304    11304           
  Misses      13144    13144           
  Partials      826      826           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mboersma
Copy link
Contributor Author

mboersma commented Dec 5, 2025

/test pull-cluster-api-provider-azure-e2e
/test pull-cluster-api-provider-azure-e2e-windows

@mboersma
Copy link
Contributor Author

mboersma commented Dec 5, 2025

/test pull-cluster-api-provider-azure-e2e-optional

Makefile Outdated
export GO111MODULE=on

# Kubebuilder.
export KUBEBUILDER_ENVTEST_KUBERNETES_VERSION ?= 1.32.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump this too.

@mboersma
Copy link
Contributor Author

mboersma commented Dec 5, 2025

/test pull-cluster-api-provider-azure-e2e-windows

Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold for tests

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 71474c84efc08656a78545feb589c4fae4b98ec6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2025
@mboersma
Copy link
Contributor Author

mboersma commented Dec 5, 2025

/test pull-cluster-api-provider-azure-e2e

Hopefully a transient failure:

bd3cdfae1d3f: Pushed
bff7f7a9d443: Pushed
8fa10c0194df: Pushed
Head "https://capzcicommunity.azurecr.io/v2/cluster-api-azure-controller-amd64/blobs/sha256:60c486bde9131ad9d48215e39950858ed421f4ed76a775265dc4e9f51839f74b": net/http: TLS handshake timeout

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 5, 2025

@mboersma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-aks d776dfe link true /test pull-cluster-api-provider-azure-e2e-aks
pull-cluster-api-provider-azure-e2e-windows d776dfe link false /test pull-cluster-api-provider-azure-e2e-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo
Copy link
Member

damdo commented Dec 6, 2025

/test pull-cluster-api-provider-azure-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants