Skip to content

Conversation

@MohitMaliFtechiz
Copy link
Collaborator

Fixes #4213

Moved shortcut creation to lifecycleScope to free up the main thread. This ensures the UI remains responsive while shortcuts are being created.

KiwixApp.mp4
CustomApp.mp4

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.24%. Comparing base (549bb5a) to head (7474d7e).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...rg/kiwix/kiwixmobile/core/main/CoreMainActivity.kt 66.66% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4214      +/-   ##
============================================
+ Coverage     56.99%   57.24%   +0.25%     
- Complexity     1546     1561      +15     
============================================
  Files           313      313              
  Lines         13600    13602       +2     
  Branches       1703     1704       +1     
============================================
+ Hits           7751     7787      +36     
+ Misses         4672     4635      -37     
- Partials       1177     1180       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…tion shortcuts.

* Moved shortcut creation to `lifecycleScope` with `Dispatchers.IO` to free up the main thread.
* This ensures the UI remains responsive while shortcuts are being created.
@kelson42 kelson42 merged commit a2341ba into main Feb 7, 2025
28 checks passed
@kelson42 kelson42 deleted the Fixes#4213 branch February 7, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Input dispatching timed out error while creating the application shortcuts.

4 participants