Skip to content

Conversation

@AriPerkkio
Copy link
Contributor

Fixes #3093

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #3098 (c70163d) into master (f93f90a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3098   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         118      118           
  Lines        7855     7857    +2     
  Branches     2801     2802    +1     
=======================================
+ Hits         7662     7664    +2     
  Misses        193      193           
Impacted Files Coverage Δ
lib/rules/no-arrow-function-lifecycle.js 96.96% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93f90a...c70163d. Read the comment docs.

@AriPerkkio AriPerkkio marked this pull request as draft October 5, 2021 13:54
@AriPerkkio
Copy link
Contributor Author

AriPerkkio commented Oct 5, 2021

Setting this as draft for now as some old Node + ESLint combinations were failing to parse arrow functions for some reason. Github Action seem to have some trouble running now so cannot verify whether latest commit fixed anything.

@ljharb
Copy link
Member

ljharb commented Oct 5, 2021

I don't believe we can use the new TS parser on older eslint versions.

@AriPerkkio
Copy link
Contributor Author

Oh right the ESLint version exclusion is done by the parsers.TS() call. Now that it's used the tests are passing.

@AriPerkkio AriPerkkio marked this pull request as ready for review October 5, 2021 17:17
@ljharb ljharb added the hacktoberfest-accepted If you're interested in a free shirt, this PR counts towards it. label Oct 6, 2021
@ljharb ljharb merged commit c70163d into jsx-eslint:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted If you're interested in a free shirt, this PR counts towards it.

Development

Successfully merging this pull request may close these issues.

Results of weekly scheduled smoke test

3 participants