Skip to content

Conversation

@MartinKolarik
Copy link
Member

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Nov 20, 2025

Walkthrough

This change modifies the GraphQL query in the GitHub repository module to include private sponsorships in paginated results. The SponsorshipsAsMaintainer query is updated with the includePrivate: true parameter in the GitHub repository handler for the sponsors cron job. The modification enables the query to fetch both public and private sponsorship data. No other logic changes are present, and no exported or public entity signatures have been altered.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning No description was provided by the author, making it impossible to evaluate whether it relates to the changeset. Add a pull request description explaining the purpose of including private sponsorships and any relevant context for reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding private sponsorships to the GetOrgSponsors query.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch private-sponsors

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b2a779 and 8c21c8b.

📒 Files selected for processing (1)
  • src/extensions/operations/sponsors-cron-handler/src/repositories/github.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{vue,ts,js}

⚙️ CodeRabbit configuration file

We use Nuxt with auto imports enabled. Don't warn about missing imports.

Files:

  • src/extensions/operations/sponsors-cron-handler/src/repositories/github.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Run e2e tests
  • GitHub Check: build
  • GitHub Check: Run e2e tests
  • GitHub Check: build
🔇 Additional comments (1)
src/extensions/operations/sponsors-cron-handler/src/repositories/github.ts (1)

32-32: Confirm GitHub token scopes and behavior when includePrivate is not allowed

Adding includePrivate: true may require additional PAT scopes (sponsors-related / org-level permissions). If those are missing in env.GITHUB_ACCESS_TOKEN, this call can start failing instead of just omitting private sponsors, potentially breaking the whole cron job.

Consider:

  • Verifying the required scopes in the GitHub GraphQL docs and updating the token configuration / runbook accordingly.
  • Deciding whether you want a fallback (e.g., retry without includePrivate) if the API returns a permission error, so the job still processes public sponsors instead of failing outright.

Comment @coderabbitai help to get the list of available commands and usage tips.

@MartinKolarik MartinKolarik merged commit d9608f5 into master Nov 21, 2025
5 checks passed
@MartinKolarik MartinKolarik deleted the private-sponsors branch November 21, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants