Skip to content

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Oct 19, 2025

Pull Request for Issue #45536 .

Summary of Changes

Mark already selected elements with checkmark, based on @travisrisner idea

Screenshot 2025-10-19_13-06-56

Testing Instructions

Run npm install

Please follow #45536

Or open Articles list and filter by category (or few).
After filtering check the category filter dropdown. There should be marked already selected items.

Actual result BEFORE applying this Pull Request

Already selected items not marked

Expected result AFTER applying this Pull Request

Already selected items is marked

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

@Fedik The CSS linter complains: https://github.com/joomla/joomla-cms/actions/runs/18629158166/job/53111418382?pr=46328

@brianteeman
Copy link
Contributor

Please use the logical css propery inset-inline-end instead of right or it will not work as intended in an RTL language

right

image

inset-inline-end

image

@Fedik
Copy link
Member Author

Fedik commented Oct 21, 2025

updated

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 20d03ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46328.

1 similar comment
@travisrisner
Copy link
Contributor

I have tested this item ✅ successfully on 20d03ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46328.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46328.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 21, 2025
@richard67 richard67 added this to the Joomla! 5.4.1 milestone Oct 21, 2025
@muhme
Copy link
Contributor

muhme commented Oct 21, 2025

✅ Final test before merge with JBT 5.4-dev

  • Before the PR
    • Installed Testing Sample Data, seen article view in selecting categories is not marking selected categories
  • PR applied with gh pr checkout 46328 and npm ci
  • Selected entries are marked, one and mulitple entries are mark-able, deselecting is working, tested with Firefox, Chrome, Safari and Edge

@muhme muhme merged commit aeb9687 into joomla:5.4-dev Oct 21, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 21, 2025
@muhme
Copy link
Contributor

muhme commented Oct 21, 2025

Thank you @Fedik for your contribution. Thank you @richard67 and @brianteeman for your support. Thank you @brianteeman and @travisrisner for testing.

@Fedik Fedik deleted the fancy-select-mark-selected branch October 21, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.4-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants