[5.4] Improve Pre-Update Check for Joomla ‎6.0.0: fix confusing message + additional notices #46324

cyrez · 2025-10-19T01:01:43Z

Pull Request for Issue reported on Mattermost and forum: confusing message about the compatibility plugin for Joomla 5 before updating to J6.
In addition, it adds a notice message for each requirement that is not met.

Note

PR updated with a new proposal.
Update 2: new language strings (Action required instead of Error + integration of @brianteeman proposal #46326 for unchecked state )

Summary of Changes

Displays only translated plugin name
Use Enabled — Disabled instead of Yes — No
Set a $option->text for badge text in checked column

Testing Instructions

Test on a Joomla 5.4 install
Check that the Behaviour - Backward Compatibility is enabled
In Joomla updater options, set 'Update Channel' on 'Next'
Check for Joomla update
Control Pre-Update Check for Joomla ‎6.0.0 'Require Settings'.
Apply patch
Check whether the pre-update information about the compatibility plugin is clearer.

Actual result BEFORE applying this Pull Request

Confusing text:

The 'Behaviour - Backward Compatibility' plugin is disabled No
Go to 'System - Manage - Plugins' and disable the plugin

Screenshot 2025-10-19 at 18-41-00 Joomla Update - W3biC - Administration

Expected result AFTER applying this Pull Request

Clear statement text:

Behaviour - Backward Compatibility Action Required (if not ok)
Go to 'System - Manage - Plugins' and disable the plugin

Not OK state:

Screenshot 2025-10-19 at 18-56-46 Joomla Update - DEV iCagenda J5 - Administration

OK state:

Screenshot 2025-10-19 at 18-32-24 Joomla Update - DEV iCagenda J5 - Administration

Full list with additional notices

All is NOT OK:

Screenshot 2025-10-21 at 17-15-17 Joomla Update - DEV iCagenda J5 - Administration

All is OK:

Screenshot 2025-10-19 at 18-33-09 Joomla Update - DEV iCagenda J5 - Administration

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: add recover information from https://manual.joomla.org/migrations/44-50/compat-plugin/#why-should-you-try-to-disable-the-plugin to https://manual.joomla.org/migrations/54-60/compat-plugin/
No documentation changes for manual.joomla.org needed

richard67 · 2025-10-19T07:53:16Z

So while without your PR the information if the check result is good or bad was visible by colours green and red and the text, yes is alway good and no always bad.

Now with this PR only the color shows if the result is good or bad.

In my opinion that's an accessibility flaw.

brianteeman · 2025-10-19T08:21:21Z

The column header is "Checked" so changing the text in that column to enabled or disabled makes no sense - especially to a screenreader

Perhaps a better solution is to have better text

richard67 · 2025-10-19T08:28:05Z

@brianteeman Maybe it would also help to make the check conditions (title) be questions? E.g. "Is the database supported?" yes/no, "Is the Behavior - Backward Compatibility plugin disabled?" yes/no, and so on, with yes alwaqys good and green, no always red and bad.

If so: Would that be a change in the meaning of the language strings so it would fall under our b/c policy, so it needs new keys and deprecate the old ones for removal in 7.0?

richard67 · 2025-10-19T08:29:50Z

@brianteeman Could make sense to provide legends for the tables in addition so you know the title on the left side is the condition, the button on the right side is the result, and if something's wrong the optional text below the title is the instruction to fix it?

brianteeman · 2025-10-19T08:37:36Z

The column headings are correct

It just needs better description/advice as I suggested above

brianteeman · 2025-10-19T08:50:25Z

See #46326 for an alternative proposal

cyrez · 2025-10-19T09:25:14Z

This was a simple clarification of the confusing information only with minor changes.
But all this would need a full refactoring as it’s not the best about UX and accessibility.
If the column label is Checked, so the yes/no is not better; it should be a checkbox or a ✅ indicator.
I can work on an another PR for that, but may need more time to be validated.

cyrez · 2025-10-19T10:06:20Z

~~I close this PR to work on another more advanced one.~~

Re-open with a better proposal!

…pre-checking the update to the next major version.

cyrez · 2025-10-19T11:54:04Z

@brianteeman you mentionned on Mattermost a valid point:

BTW even if your site fails all the required checks you are still offered the option to "upload and update"

We can do another PR for this?

Something like this, maybe:

brianteeman · 2025-10-19T11:57:22Z

I do not agree with this. It is not an error. The column header is checked so saying it's value is error is wrong

richard67 · 2025-10-19T11:59:11Z

So we have 3 alternative PRs for the same thing, this one here, #46326 by @brianteeman and #46327 by @chmst .

cyrez · 2025-10-19T11:59:22Z

Updated PR

Note for @brianteeman : it's possible to integrate your new language strings when the plugin compat for J5 is enabled only (and keep it simple when it's OK)?

cyrez · 2025-10-19T12:02:41Z

I do not agree with this. It is not an error. The column header is checked so saying it's value is error is wrong

I've tried with existing language strings, but what could be a better wording? "Warning", "Failed", "incorrect"...
As this label should work for all Requirements states.

richard67 · 2025-10-19T12:07:12Z

How about combining all 3 PRs?

Use the titles from @chmst 's PR [5.4] Simplify preupdate check text for compatibility plugin #46327 .
Use the notices from @brianteeman 's PR [5.4] Update check for BC plugin #46326 .
Leave the "Yes" and "No" texts for the result as they are but add the check marks or cross marks from this PR here.

richard67 · 2025-10-19T12:09:20Z

P.S.: An aspect to be considered is our b/c policy for language strings. We cannot change the meaning in a patch version.

@brianteeman As you are the native speaker in our little 3 PR club: Do you see any problems with that in any of the 3 PRs?

brianteeman · 2025-10-19T12:12:40Z

@richard67 my pr introduced new strings so there is no BC issue

@cyrez the check is yes/no if you say fail that implies the check failed not that the result is no

richard67 · 2025-10-19T12:14:37Z

@richard67 my pr introduced new strings so there is no BC issue

@brianteeman Would Christiane's PR mean a meaning change for the title strings?

cyrez · 2025-10-21T13:05:22Z

Are there some language strings which become obsolete as this PR adds new strings? If so, the obsolete strings should be deprecated with a corresponding comment for removal in 7.0.

Added the deprecated strings in 7.0 ;)

richard67 · 2025-10-21T13:16:33Z

What seems inconsistent to me (at least in the screenshots in the description):

When the condition for the Joomla 5 b/c plugin fails, the title is "The 'Behaviour - Backward Compatibility' Plugin Must be Disabled".
When the condition for the Joomla 6 b/c plugin fails, the title is "Behaviour - Backward Compatibility 6"

For consistency I would expect the latter to be: "The 'Behaviour - Backward Compatibility 6' Plugin Must be Enabled".

cyrez · 2025-10-21T15:00:00Z

What seems inconsistent to me (at least in the screenshots in the description):
* When the condition for the Joomla 5 b/c plugin fails, the title is "The 'Behaviour - Backward Compatibility' Plugin Must be Disabled".

* When the condition for the Joomla 6 b/c plugin fails, the title is "Behaviour - Backward Compatibility 6"
For consistency I would expect the latter to be: "The 'Behaviour - Backward Compatibility 6' Plugin Must be Enabled".

Is it required if no B/C issue? For example, if you use only Joomla 5.4 with no third-party extension installed, is it needed to have the compat 6 enabled?

cyrez · 2025-10-21T15:04:06Z

Note: i can add those strings for now.
But maybe the global logic can be reviewed in the case no third-party extensions could break the site on J6. (by security, to not block update only if zero third-party extensions installed)?

IMO, this could be another PR...

cyrez · 2025-10-21T15:17:03Z

What seems inconsistent to me (at least in the screenshots in the description):
* When the condition for the Joomla 5 b/c plugin fails, the title is "The 'Behaviour - Backward Compatibility' Plugin Must be Disabled".

* When the condition for the Joomla 6 b/c plugin fails, the title is "Behaviour - Backward Compatibility 6"
For consistency I would expect the latter to be: "The 'Behaviour - Backward Compatibility 6' Plugin Must be Enabled".

Updated!
Screenshot with all not OK updated in the PR description.

Is everything OK now? :-)

richard67 · 2025-10-21T15:42:59Z

Note: i can add those strings for now. But maybe the global logic can be reviewed in the case no third-party extensions could break the site on J6. (by security, to not block update only if zero third-party extensions installed)?

IMO, this could be another PR...

I don't see the need for such a change. Not everything which needs the Joomla 6 b/c plugin must be a 3rd party extension, it could also be an override, and all those cannot be checked. So better safe than sorry and force people to enable the J6 b/c plugin before the update.

Is everything OK now? :-)

Seems so.

@ChristineWk @dautrich Could you test again with the latest changes? Thanks in advance.

dautrich · 2025-10-21T17:56:32Z

I have tested this item ✅ successfully on d0508b6

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46324.}

dautrich · 2025-10-21T17:57:11Z

@richard67 Done

ChristineWk · 2025-10-21T19:51:29Z

I have tested this item ✅ successfully on d0508b6

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46324.}

ChristineWk · 2025-10-21T19:52:49Z

OT: I always had the GitHub token.
I got a message saying it was missing. I don't know why.
I re-entered it...

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46324.}

richard67 · 2025-10-21T20:20:08Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46324.}

muhme · 2025-10-22T08:14:06Z

✅ Final test before merge with JBT 5.4-dev

Before the PR, seen the confusing double Negation
'Behaviour - Backward Compatibility' plugin is disabled No
with enabled 'Behaviour - Backward Compatibility' plugin
Applied PR with gh pr checkout 46324
- Checked everything red and the suggestions and links are correct
  - Set mbstring.language = Japanese in php.ini file and checked the recommended .htaccess fix is working
  - Enabled 'Behaviour - Backward Compatibility' and disabled 'Behaviour - Backward Compatibility 6'
  - Remaining tests set to false by hacking -> state = false;
  - Links are going to Requirements for Joomla! 6.x
  - ⚠️ Not to disable parse_ini_string PHP function is not named in Requirements for Joomla! 6.x -> I will handle this in parallel -> [5.4] Remove the useless INI Parser support #46359
  - ⚠️ 54-60/compat-plugins is not up-to-date -> I will handle this together with 6.0 RMs -> migrations/54-60/compat-plugin update Manual#548
- Checked everything is green
- Tested in light and dark mode

muhme · 2025-10-22T08:27:05Z

👍 Thank you @cyrez for your contribution. Thank you @brianteeman, @richard67, @chmst and @Webdongle for supporting this PR. Thank you @ChristineWk and @dautrich for testing.

cyrez · 2025-10-22T10:02:26Z

Thank you @ChristineWk and @dautrich for testing.
Thank you too @chmst @brianteeman and @richard67 for your review, help and suggestion!

* As named as one requirement in Pre-Update Check improvements PR [46324](joomla/joomla-cms#46324) and linked to this place extended one line for 6.x with `parse_ini_string`. * As checked it is already included in 4.4.14 `administrator/components/com_joomlaupdate/src/Model/UpdateModel.php`, also added for 5.x. * Trailing spaces removed.

Update is caused by [joomla-cms/pull/46324](joomla/joomla-cms#46324) which links to `migrations/54-60/compat-plugin`. * Removed four times 'not been released yet' as Joomla 6.0 is released * Changes title from singular to plural, but not the file name, as it used as link in the PR above. * Rewritten the main content (the two b/c plugins) from Joomla 6 view. * Named exactly 'Behaviour - Backward Compatibility 6', as we have also 'Behaviour - Backward Compatibility' plugin. * Moved DEVELOPER NOTE to the end, as it is a secondary information. * Added list of PRs for the 'Behaviour - Backward Compatibility 6'. * Is this list complete? * Is the list useful? * Added a note for NEW INSTALLATION as we saw the question multiple times, even it is not direct related to the migration. * Merged the given infos from the three deleted and to b/c plugin moved functionality into 'Removed and Backward Incompatibility' and linked this page. * Is the merge correct? * Line breaks at 120 chars.

* migrations/54-60/compat-plugin update Update is caused by [joomla-cms/pull/46324](joomla/joomla-cms#46324) which links to `migrations/54-60/compat-plugin`. * Removed four times 'not been released yet' as Joomla 6.0 is released * Changes title from singular to plural, but not the file name, as it used as link in the PR above. * Rewritten the main content (the two b/c plugins) from Joomla 6 view. * Named exactly 'Behaviour - Backward Compatibility 6', as we have also 'Behaviour - Backward Compatibility' plugin. * Moved DEVELOPER NOTE to the end, as it is a secondary information. * Added list of PRs for the 'Behaviour - Backward Compatibility 6'. * Is this list complete? * Is the list useful? * Added a note for NEW INSTALLATION as we saw the question multiple times, even it is not direct related to the migration. * Merged the given infos from the three deleted and to b/c plugin moved functionality into 'Removed and Backward Incompatibility' and linked this page. * Is the merge correct? * Line breaks at 120 chars. * Fixing "during the upgrade process" * Fixed link

joomla/joomla-cms#46337 + joomla/joomla-cms#46324 + joomla/joomla-cms#46264 - (только для en-GB)

cyrez added 2 commits October 19, 2025 02:41

Improve UX: confusing message about the compatibility plugin

b9d73ed

Improve UX: confusing message about the compatibility plugin

1414145

joomla-cms-bot added the PR-5.4-dev label Oct 19, 2025

cyrez changed the title ~~Pre-Update Check for Joomla ‎6.0.0: confusing message about the compatibility plugin~~ [5.4] Pre-Update Check for Joomla ‎6.0.0: confusing message about the compatibility plugin Oct 19, 2025

cyrez closed this Oct 19, 2025

cyrez reopened this Oct 19, 2025

cyrez added 3 commits October 19, 2025 13:36

FIX UX/UI: Confusing information regarding the required settings for …

3f4a8ae

…pre-checking the update to the next major version.

FIX UX/UI: Confusing information regarding the required settings for …

5838ee5

…pre-checking the update to the next major version.

Update preupdatecheck.php

287f5e2

This was referenced Oct 19, 2025

[5.4] Update check for BC plugin #46326

Closed

[5.4] Simplify preupdate check text for compatibility plugin #46327

Closed

Add action required message to Joomla update language file

0e9aaf9

joomla-cms-bot added the Language Change This is for Translators label Oct 19, 2025

cyrez added 2 commits October 21, 2025 17:10

Update plugin compat 6 label based on state

77d3a0a

Add label for enabling the compatibility 6 plugin when disabled

d0508b6

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 21, 2025

Merge branch '5.4-dev' into patch-61

f1fe4ee

muhme merged commit e17e58d into joomla:5.4-dev Oct 22, 2025
40 checks passed

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 22, 2025

muhme added this to the Joomla! 5.4.1 milestone Oct 22, 2025

muhme mentioned this pull request Oct 22, 2025

Technical Requirements – Added parse_ini_string joomla/Manual#546

Closed

jgerman-bot mentioned this pull request Oct 23, 2025

[5.4] Improve Pre-Update Check for Joomla ‎6.0.0: fix confusing message + additional notices joomlagerman/joomla#3631

Closed

joomlapl-bot mentioned this pull request Oct 23, 2025

[5.4] Improve Pre-Update Check for Joomla ‎6.0.0: fix confusing message + additional notices JoomlaPolska/jezyk-J4#871

Open

muhme mentioned this pull request Oct 28, 2025

migrations/54-60/compat-plugin update joomla/Manual#548

Merged

richard67 mentioned this pull request Nov 22, 2025

[6.0] sysinfo compat6 #46410

Merged

4 tasks

Kostelano added a commit to JPathRu/localisation that referenced this pull request Nov 24, 2025

Новое в Joomla 5.4.1 Stable

52ba241

joomla/joomla-cms#46337 + joomla/joomla-cms#46324 + joomla/joomla-cms#46264 - (только для en-GB)

Uh oh!

[5.4] Improve Pre-Update Check for Joomla ‎6.0.0: fix confusing message + additional notices #46324

[5.4] Improve Pre-Update Check for Joomla ‎6.0.0: fix confusing message + additional notices #46324

Uh oh!

Conversation

cyrez commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Full list with additional notices

Link to documentations

Uh oh!

richard67 commented Oct 19, 2025

Uh oh!

brianteeman commented Oct 19, 2025

Uh oh!

richard67 commented Oct 19, 2025

Uh oh!

richard67 commented Oct 19, 2025

Uh oh!

brianteeman commented Oct 19, 2025

Uh oh!

brianteeman commented Oct 19, 2025

Uh oh!

cyrez commented Oct 19, 2025

Uh oh!

cyrez commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyrez commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented Oct 19, 2025

Uh oh!

richard67 commented Oct 19, 2025

Uh oh!

cyrez commented Oct 19, 2025

Uh oh!

cyrez commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Oct 19, 2025

Uh oh!

brianteeman commented Oct 19, 2025

Uh oh!

richard67 commented Oct 19, 2025

Uh oh!

cyrez commented Oct 21, 2025

Uh oh!

richard67 commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyrez commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyrez commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyrez commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Oct 21, 2025

Uh oh!

dautrich commented Oct 21, 2025

Uh oh!

dautrich commented Oct 21, 2025

Uh oh!

ChristineWk commented Oct 21, 2025

Uh oh!

ChristineWk commented Oct 21, 2025

Uh oh!

richard67 commented Oct 21, 2025

Uh oh!

muhme commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cyrez commented Oct 19, 2025 •

edited

Loading

cyrez commented Oct 19, 2025 •

edited

Loading

cyrez commented Oct 19, 2025 •

edited

Loading

cyrez commented Oct 19, 2025 •

edited

Loading

richard67 commented Oct 19, 2025 •

edited

Loading

richard67 commented Oct 21, 2025 •

edited

Loading

cyrez commented Oct 21, 2025 •

edited

Loading

cyrez commented Oct 21, 2025 •

edited

Loading

cyrez commented Oct 21, 2025 •

edited

Loading

muhme commented Oct 22, 2025 •

edited

Loading