[5.4] fix update notification scheduled task

[heelc29]

Pull Request for Issue #46308 .

Summary of Changes

Fix data type for AutoupdateRegisterState must be of type int, string given
This happens only on updated sites, because the param entry for update_status is not present in database and so the default parameter of ->get() is used.

Now the same integer default value is used like here (Unsubscribed):

joomla-cms/administrator/components/com_joomlaupdate/src/Controller/UpdateController.php

Line 738 in 08ae2c6

$registrationState = AutoupdateRegisterState::tryFrom($params->get('autoupdate_status', 0));

joomla-cms/administrator/components/com_joomlaupdate/src/Enum/AutoupdateRegisterState.php

Lines 20 to 26 in 08ae2c6

	enum AutoupdateRegisterState: int
	{
	case Unsubscribe = -1;
	case Unsubscribed = 0;
	case Subscribe = 1;
	case Subscribed = 2;
	}

Testing Instructions

• Update Joomla form 5.3.x to 5.4.x
• Run test for Update Notification task

Actual result BEFORE applying this Pull Request

Scheduled task fails

PHP error message in server response

Task is locked

Expected result AFTER applying this Pull Request

Scheduled task should work

Link to documentations

Please select:

• No documentation changes for docs.joomla.org needed
• No documentation changes for manual.joomla.org needed

[richard67]

I have tested this item ✅ successfully on f5aa259

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46315.}

[alikon]

I have tested this item ✅ successfully on f5aa259

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46315.}

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46315.}

[muhme]

✅ Final test before merge with JBT recreate 5.3.3 (as for 5.3.4 composer i failed)

• Manual updated by upload with nightly 5.4-dev, Scheduled Task 'Update Notification' fails with 'No content was returned.'
• Second test with PRs update package and there are no more problems running the Scheduled Task 'Update Notification'

[muhme]

Thank you @heelc29 for your contribution. Thank you @richard67 and @alikon for testing.

[Sieger66]

I think after update to 5.4.0 it have many sites with locked task "Update Notification" and this block all other tasks in the Task Scheduler.
I do not know it is usefull to do

UPDATE `#__scheduler_tasks` SET `locked`=NULL WHERE `type`='update.notification';

with the next Joomla-Update-Version to fix this problem?

PR #46315 not change locked status of "Update Notification" of the Task Scheduler in the database.

[richard67]

I don’t think we should do that for all sites on update.

By the way, you can also unlock the locked tasks which have that running man icon by clicking on that icon.

[Sieger66]

I know this all.
But on many amateur websites the not executed Scheduler Task "Session GC" overload the database if all tasks in the Task Scheduler are blocked by locked task "Update Notification".

Other minimal solution: Information after next Joomla-Update to check the Task Scheduler of locked tasks and unlock information.

I think it is better to do anything before many amateur websites crashed with full database.