Skip to content

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Oct 16, 2025

Pull Request for Issue # .

Summary of Changes

Links inside alerts do not get underlined

Testing Instructions

Easiest test is to install this plugin https://github.com/brianteeman/slashtools/releases/tag/1.0.2
On install an alert is displayed but you cannot "see" the link

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Links inside alerts do not get underlined

Signed-off-by: BrianTeeman <[email protected]>
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.4-dev labels Oct 16, 2025
@travisrisner
Copy link
Contributor

I have tested this item ✅ successfully on 588443b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46298.

@exlemor
Copy link

exlemor commented Oct 17, 2025

I have tested this item ✅ successfully on 588443b

Tested this super easy PR successfully. Thanks @brianteeman!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46298.

@QuyTon
Copy link
Contributor

QuyTon commented Oct 17, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46298.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 17, 2025
@muhme
Copy link
Contributor

muhme commented Oct 17, 2025

✅ 46298 Final test with JBT before merge: No underscore for link

  • Applied PR with gh pr checkout 46298 and npm ci – the link is now underscored

@muhme muhme merged commit 08ae2c6 into joomla:5.4-dev Oct 17, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 17, 2025
@muhme muhme added this to the Joomla! 5.4.1 milestone Oct 17, 2025
@muhme
Copy link
Contributor

muhme commented Oct 17, 2025

Thank you @brianteeman for your contribution. Thank you @travisrisner and @exlemor for testing.

@brianteeman brianteeman deleted the alert branch October 17, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.4-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants