Skip to content

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Oct 6, 2025

Pull Request for Issue # .

Summary of Changes

Fix return type for App getDocument() and getLanguage() methods.

Note: These objects are not initialized in the Application constructor but at different stage of Application execution and so cannot be always available.

I not sure where this PR should go, made to 5.4 for now.

Testing Instructions

Code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

I have tested this item ✅ successfully on ff85927

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46238.

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on ff85927


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46238.

@joomdonation
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46238.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 19, 2025
@joomdonation joomdonation added this to the Joomla! 5.4.1 milestone Oct 19, 2025
@muhme muhme merged commit 2ae53f1 into joomla:5.4-dev Oct 20, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 20, 2025
@muhme
Copy link
Contributor

muhme commented Oct 20, 2025

Thank you @Fedik for your contribution. Thank you @richard67 and @joomdonation for test by review.

@muhme
Copy link
Contributor

muhme commented Oct 20, 2025

✅ Final check before merge was: Code review: It only corrects the PHPDoc, no code or behaviour change

@Fedik Fedik deleted the fix-app-return-type-doc-lang branch October 20, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants