-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.4] Add mysql to test matrix and proper min max db versions #46186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af0cd94 to
6f2b73c
Compare
muhme
approved these changes
Oct 23, 2025
Contributor
muhme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New added GitHub actions were running multiple times successful
- All Joomla 5.x min and current LTS versions are in use
- Used PHP versions: 8.1, 8.2, 8.3 and 8.4
- Used MySQL versions: 8.0.13 and 8.4
- User MariaDB versions: 10.4 and 12.0
- Used PostgreSQL versions: 12.0 and 18.0
- System tests are running with Google Chrome and Microsoft Edge with all three databases min and max versions
Member
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-5.4-dev
Unit/System Tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for pr #46180.
Summary of Changes
Adds Mysql to the integration and system test matrix and proper min/max versions for the databases.
Additionally I had to migrate to the node mysql2 package, which handles the authentication properly.
When upmerged to 6, then the versions should be updated according to the requirements of Joomla 6.
Testing instructions
Verifying GitHub actions with minimum technical-requirements and max available stable version.