-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Fix DELETE endpoints to return 404 for non-existent resources #46161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have tested this item ✅ successfully on f9f4ac1
Thank you 👍 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46161. |
|
I have tested this item ✅ successfully on f9f4ac1 thanks @alikon This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46161. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46161. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #46095 .
Summary of Changes
This PR fixes the DELETE endpoints to properly return HTTP 404 status code when attempting to delete non-existent resources, instead of returning 204 (No Content).
Testing Instructions
execute a DELETE for a non-existent resource es:
/api/index.php/v1/contacts/99999Actual result BEFORE applying this Pull Request
DELETE /api/v1/contacts/9999 returned 204 (No Content)
Expected result AFTER applying this Pull Request
DELETE /api/v1/contacts/9999 returns 404 (Not Found) with error message
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed