-
Notifications
You must be signed in to change notification settings - Fork 19
Added flag to invoke doStop on WorkflowRun instead of throwing FlowInterruptedException #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…terruptedException
|
Interesting, my experience was the opposite: with |
|
Indeed interesting. I agree, that the flag is not a pretty solution. Just wanted to try if it works... If possible (server is not entierly under my control), I'll install a custom build in order to verify my assumption |
|
@zbynek did you manage to figure something out? Otherwise it would be great to if consider merging this issue as a workaround. I know that a flag is not to pretty but it is better then nothing |
|
@cconnert sorry, I forgot about this. |
|
@zbynek: Currently it seems that the aborts to work. I'll monitor our release pipelines and get back to this issue |
|
Hey! Just to understand the plugin behavior before installing it. Is my understanding correct in that with a pipeline build, the build itself will be reported as a failure because of it being aborted? |
|
@lppedd no, it will have a status of NOT_BUILT. |
|
@zbynek I might be missing some configuration related to the GitHub integration. |

Currently the scmSkip does not work as expected in our multi branch pipeline. The build continues to run and only is properly aborted sometimes. Still aborting the build in the JenkinsUI does work. Thus I added a backwards compatible flag to invoke the doStop on a WorkflowRun instead of throwing an execption.
Testing done
Added new unit test to cover new flag