Skip to content

Conversation

@bradsawadye
Copy link
Contributor

No description provided.

These are the config files for applying eslint styling to the codebase

OHM-1082
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #1142 (3545739) into 6.0.0-alpha.1 (cec6e6b) will decrease coverage by 1.64%.
The diff coverage is 76.66%.

❗ Current head 3545739 differs from pull request most recent head 9b3864f. Consider uploading reports for the commit 9b3864f to get more accurate results
Impacted file tree graph

@@                Coverage Diff                @@
##           6.0.0-alpha.1    #1142      +/-   ##
=================================================
- Coverage          84.36%   82.72%   -1.65%     
=================================================
  Files                 80       80              
  Lines               5661     5893     +232     
=================================================
+ Hits                4776     4875      +99     
- Misses               885     1018     +133     
Impacted Files Coverage Δ
src/config/config.js 80.00% <ø> (ø)
src/middleware/retrieveTCPTransaction.js 100.00% <ø> (ø)
src/migrateMetrics.js 0.00% <0.00%> (ø)
src/reports.js 29.53% <16.66%> (+0.24%) ⬆️
src/api/events.js 27.27% <20.00%> (ø)
src/api/certificateAuthority.js 90.19% <50.00%> (ø)
src/middleware/proxy.js 88.88% <50.00%> (-11.12%) ⬇️
src/middleware/streamingReceiver.js 42.59% <50.00%> (-0.27%) ⬇️
src/middleware/streamingRouter.js 68.57% <53.33%> (ø)
src/api/restart.js 81.48% <57.14%> (-3.14%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c718948...9b3864f. Read the comment docs.

.eslintrc.json Outdated
"rules": {
"require-atomic-updates": "off" // should be defaulted to "off" soon: https://github.com/eslint/eslint/issues/11899
}
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this suggestion here?

@MattyJ007 MattyJ007 merged commit dc17ec1 into 6.0.0-alpha.1 Sep 14, 2021
@MattyJ007 MattyJ007 deleted the OHM-1082-add-eslint-alpha branch September 14, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants