Fix packaged dlls not found #7108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
fegorsch
force-pushed
the
fix-package-dlls-not-found
branch
2 times, most recently
from
0d24ec9 to
d28f514
Compare
This PR introduced `winmode=0` for loading DLLs during import: isl-org#5259 This however leads to directories added via `os.add_dll_directory` not being considered, when loading DLLs (see isl-org#7104 (comment)). In particular this leads to open3d/tbb12.dll not being found. Fix this by going back to the default DLL-search mode (`winmode=None`). In order to still be able to find CUDA-DLLs, that are not part of the open3d-package, search their directory in PATH and explicitly add it to the DLL-search-locations for CUDA-builds.
fegorsch
force-pushed
the
fix-package-dlls-not-found
branch
from
d28f514 to
9b67487
Compare
ssheorey
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
This PR introduced
winmode=0for loading DLLs during import. This however leads to directories added viaos.add_dll_directorynot being considered, when loading DLLs (see here or here). In particular this leads toopen3d/tbb12.dllnot being found.Fix this by going back to the default DLL-search mode (
winmode=None).In order to still be able to find CUDA-DLLs, that are not part of the open3d-package, search their directory in PATH and explicitly add it to the DLL-search-locations for CUDA-builds.
Note that this PR results in DLLs generally not being searched in
PATHanymore, when importingopen3d, as is the default behaviour of Python-packages since 3.8. The exception are CUDA-libraries in the heuristically determined directory. If anyone relies onPATHbeing searched, this PR breaks functionality.Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description