Skip to content

Changed o3c.Tensor.arange signature to be like np.arange. #7095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssheorey merged 2 commits into from
Dec 16, 2024
Merged

Changed o3c.Tensor.arange signature to be like np.arange. #7095

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4badc6
Changed Tensor.arange signature to be like in numpy.
timohl Aug 31, 2024
3dd0be0
Merge branch 'isl-org:main' into tensor-arange-signature
timohl Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions cpp/pybind/core/tensor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,22 +394,22 @@ void pybind_core_tensor_definitions(py::module& m) {
},
"Create a 1D tensor with evenly spaced values in the given "
"interval.",
"stop"_a, "dtype"_a = py::none(), "device"_a = py::none());
"stop"_a, py::pos_only(), py::kw_only(), "dtype"_a = py::none(),
"device"_a = py::none());
tensor.def_static(
"arange",
[](utility::optional<int64_t> start, int64_t stop,
utility::optional<int64_t> step, utility::optional<Dtype> dtype,
[](int64_t start, int64_t stop, utility::optional<int64_t> step,
utility::optional<Dtype> dtype,
utility::optional<Device> device) {
return Tensor::Arange(
start.has_value() ? start.value() : 0, stop,
step.has_value() ? step.value() : 1,
start, stop, step.has_value() ? step.value() : 1,
dtype.has_value() ? dtype.value() : core::Int64,
device.has_value() ? device.value() : Device("CPU:0"));
},
"Create a 1D tensor with evenly spaced values in the given "
"interval.",
"start"_a = py::none(), "stop"_a, "step"_a = py::none(),
"dtype"_a = py::none(), "device"_a = py::none());
"start"_a, "stop"_a, "step"_a = py::none(), "dtype"_a = py::none(),
py::kw_only(), "device"_a = py::none());

// Tensor creation from arange for float.
tensor.def_static(
Expand All @@ -423,22 +423,22 @@ void pybind_core_tensor_definitions(py::module& m) {
},
"Create a 1D tensor with evenly spaced values in the given "
"interval.",
"stop"_a, "dtype"_a = py::none(), "device"_a = py::none());
"stop"_a, py::pos_only(), py::kw_only(), "dtype"_a = py::none(),
"device"_a = py::none());
tensor.def_static(
"arange",
[](utility::optional<double> start, double stop,
utility::optional<double> step, utility::optional<Dtype> dtype,
[](double start, double stop, utility::optional<double> step,
utility::optional<Dtype> dtype,
utility::optional<Device> device) {
return Tensor::Arange(
start.has_value() ? start.value() : 0.0, stop,
step.has_value() ? step.value() : 1.0,
start, stop, step.has_value() ? step.value() : 1.0,
dtype.has_value() ? dtype.value() : core::Float64,
device.has_value() ? device.value() : Device("CPU:0"));
},
"Create a 1D tensor with evenly spaced values in the given "
"interval.",
"start"_a = py::none(), "stop"_a, "step"_a = py::none(),
"dtype"_a = py::none(), "device"_a = py::none());
"start"_a, "stop"_a, "step"_a = py::none(), "dtype"_a = py::none(),
py::kw_only(), "device"_a = py::none());

tensor.def(
"append",
Expand Down
Loading