Skip to content

Fix CI tests - macOS, Ubuntu, SYCL #7087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssheorey merged 8 commits into from
Dec 13, 2024
Merged

Fix CI tests - macOS, Ubuntu, SYCL #7087

ssheorey merged 8 commits into from
Dec 13, 2024

Conversation

@ssheorey
Copy link
Member

@ssheorey ssheorey commented Dec 5, 2024 •
edited
Loading

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

CI errors.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results       (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

  • Cache storage change: gz->xz, 5->4GB
  • Use default XCode versions (XCode 15 causes errors works with embree.)
  • Hide symbols from core and visualization to reduce Windows DLL size. Also move some geometry functions to anon namespace.
  • Add CPU fallback as the last SYCL device. Skip in testing.

@ssheorey
Cache storage change: gz->xz, 5->4GB
9c9d9d1 
Test XCode 16.3 (XCode 14 is not available on github)
XCode 15 causes errors with embree.
@update-docs
Copy link

update-docs bot commented Dec 5, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey
Use default xcode versions
6523a11 
Each macOS version now comes with a single xcode version.
Disable github sycl raycasting tests (no GPU available there).
@ssheorey
No need to unlink libomp in macOS-13
c928b2a
@ssheorey
Check for GITHUB_ACTIONS instead of CI
61fade0
@JorgePH JorgePH mentioned this pull request Dec 11, 2024
Closed
3 tasks
@ssheorey ssheorey marked this pull request as ready for review December 11, 2024 15:20
@ssheorey ssheorey requested a review from benjaminum December 11, 2024 15:20
benjaminum
benjaminum approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ssheorey ssheorey merged commit 81201f9 into main Dec 13, 2024
43 of 45 checks passed
@ssheorey ssheorey deleted the ss/ci-fix branch December 13, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminum benjaminum benjaminum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ssheorey @benjaminum