fix: Header().Has works properly for checking multiple values #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows the problem mentioned in #186
Contributor
|
Results against Kubo latest: Summary
|
Contributor
|
Results against Kubo master: Summary
|
SgtPooki
force-pushed
the
fix/header-tests
branch
from
642a571 to
9cf9d01
Compare
SgtPooki
changed the title
laurentsenta
approved these changes
May 17, 2024
Contributor
laurentsenta
left a comment
laurentsenta
left a comment
There was a problem hiding this comment.
Looks great, thanks for the patch
lidel
approved these changes
May 20, 2024
Merged
Member
|
Shipped in v0.5.2 FYSA I've added normalization step in https://github.com/ipfs/gateway-conformance/pull/208/files which fixes 9 Failures Kubo e2e reported here. |
Member
Author
|
Nice. thanks.. I was sure there was some edge case i was missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit shows the problem mentioned in #186
later commits fix the failing test
fixes #186
contributes to #21