fix(tokens): remove style dictionary scripts and reuse os tokens logic #30786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenOsodrac
added
package: core
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BenOsodrac
requested review from
brandyscarney
and removed request for
thetaPC
thetaPC
requested changes
Nov 17, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
The foundations/README.md also needs to be updated to exlcude ionic.utility.scss since that file isn't being generated anymore.
Contributor
There was a problem hiding this comment.
Revert this deletion. We use it to test on ios and md.
BenOsodrac
changed the title
brandyscarney
approved these changes
Nov 17, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
I'm approving this based on the changes but please review my comments as some of the screenshot diffs look wrong and will likely need to be addressed. 👍
...est/hint/badge.e2e.ts-snapshots/badge-hint-avatar-ionic-md-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
...ple/accordion.e2e.ts-snapshots/accordion-one-open-ionic-md-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
...ip/test/states/chip.e2e.ts-snapshots/chip-focused-ionic-md-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
...egment.e2e.ts-snapshots/segment-layout-label-only-ionic-md-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
...shape/tab-bar.e2e.ts-snapshots/tab-bar-shape-soft-ionic-md-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
...n/test/basic/button.e2e.ts-snapshots/button-diff-ionic-ios-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
brandyscarney
approved these changes
Nov 19, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
A few remaining questions but nothing blocking, code updates look good!
...shape/tab-bar.e2e.ts-snapshots/tab-bar-shape-soft-ionic-md-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
...tle/test/basic/title.e2e.ts-snapshots/title-basic-ionic-md-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
| @@ -895,18 +876,18 @@ $ion-font-weight-semi-bold: var(--token-font-weight-semi-bold, 600); | |||
| $ion-font-weight-bold: var(--token-font-weight-bold, 700); | |||
| $ion-font-weight-extra-bold: var(--token-font-weight-extra-bold, 800); | |||
| $ion-font-weight-black: var(--token-font-weight-black, 900); | |||
| $ion-font-size-275: var(--token-font-size-275, font.px-to-rem(11)); | |||
Member
There was a problem hiding this comment.
Why did we remove the px-to-rem call? Don't we need this for dynamic fonts? Or do we plan to update this later?
...ip/test/states/chip.e2e.ts-snapshots/chip-focused-ionic-md-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
brandyscarney
force-pushed
the
ROU-12316
branch
from
536af26 to
fcc4dbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
This pull request updates the design token build system and its dependencies, simplifying the process and removing custom scripts in favor of using the latest features of the
outsystems-design-tokenspackage. The changes modernize how design tokens are generated and maintained, reducing custom code and leveraging upstream improvements.Key changes include:
Build Process Simplification:
core/scripts/tokens/index.mjsandcore/scripts/tokens/utils.mjs) have been removed. Token generation is now handled directly via theoutsystems-design-tokenspackage using annpxcommand in thebuild.tokensscript. This reduces maintenance overhead and keeps the build process aligned with upstream best practices. [1] [2] [3]Dependency Updates:
outsystems-design-tokensto version1.3.3andstyle-dictionaryto version5.1.1in bothpackage.jsonandpackage-lock.json. This ensures compatibility with the latest features and bug fixes and removes the need to specifystyle-dictionarydirectly as a dependency. [1] [2] [3] [4]SCSS Utility Import:
@forward "../../foundations/ionic.utility";statement was removed fromcore/src/css/ionic/utils.bundle.ionic.scss, likely because the utility SCSS is now generated and managed by the new token build process.Removed CSS tests for Ionic theme, as they relied heavily on testing the effect of the utility-classes, that are no longer created on the ionic scope.
Does this introduce a breaking change?