Skip to content

Module.uniqueInstanceName not enforced as reserved name in Synth stack #610

@mkorbel1

Description

@mkorbel1

Describe the bug

The Module.uniqueInstanceName is supposed to be a guaranteed unique name for an instance in the context of a module hierarchy. This is nice for debug and waveform viewing, but doesn't come with guarantees on generated outputs.

We should fix the Synth stack so that when outputs are generated, the instance names of modules are guaranteed to be equal to the uniqueInstanceName. This does mean that if someone tries to reserve another name that would conflict with an auto-selected unique instance name, it will fail on the other reserved name. Since this happens during build, perhaps we can first check for reserved internal signal names to avoid such conflicts.

To Reproduce

No response

Expected behavior

No response

Actual behavior

No response

Additional: Dart SDK info

No response

Additional: pubspec.yaml

Additional: Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions