Skip to content

IBX-7441: Fixed custom attributes in link #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dew326 merged 1 commit into from
Dec 22, 2023
Merged

IBX-7441: Fixed custom attributes in link #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/bundle/Resources/public/js/CKEditor/link/ui/link-form-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ class IbexaLinkFormView extends View {
this.saveButtonView = this.createButton('Save', null, 'ck-button-save', 'save-link');
this.cancelButtonView = this.createButton('Remove link', null, 'ck-button-cancel', 'remove-link');
this.selectContentButtonView = this.createButton('Select content', null, 'ibexa-btn--select-content');
this.urlInputView = this.createTextInput('Link to');
this.titleView = this.createTextInput('Title');
this.targetSwitcherView = this.createBoolean('Open in tab');
this.urlInputView = this.createTextInput({ label: 'Link to' });
this.titleView = this.createTextInput({ label: 'Title' });
this.targetSwitcherView = this.createBoolean({ label: 'Open in tab' });
this.attributeRenderMethods = {
string: this.createTextInput,
number: this.createNumberInput,
Expand Down Expand Up @@ -237,7 +237,7 @@ class IbexaLinkFormView extends View {
}

const createAttribute = createAttributeMethod.bind(this);
const attributeView = createAttribute(config.label);
const attributeView = createAttribute(config);

this.attributeViews[`ibexaLink${name}`] = attributeView;

Expand Down Expand Up @@ -316,7 +316,7 @@ class IbexaLinkFormView extends View {
return [...selectedItems].join(' ');
}

createTextInput(label) {
createTextInput({ label }) {
const labeledInput = new LabeledFieldView(this.locale, createLabeledInputText);

labeledInput.label = label;
Expand All @@ -332,7 +332,7 @@ class IbexaLinkFormView extends View {
return labeledInput;
}

createBoolean(label) {
createBoolean({ label }) {
const labeledSwitch = new LabeledFieldView(this.locale, createLabeledSwitchButton);

this.listenTo(labeledSwitch.fieldView, 'execute', () => {
Expand Down