IBX-6077: Fixed saving custom classes and attributes on tables in OE #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Editor are not saved
…Online Editor are not saved
Closed
4 tasks
Contributor
Author
|
@ibexa/php-dev @dew326 : Please review |
vidarl
commented
Jul 17, 2023
…Online Editor are not saved
|
Kudos, SonarCloud Quality Gate passed!
|
alongosz
changed the title
alongosz
added
Feature
alongosz
changed the title
alongosz
reviewed
Jul 20, 2023
Member
alongosz
left a comment
alongosz
left a comment
There was a problem hiding this comment.
Looks ok as-is. I neeed more details here: https://github.com/ibexa/fieldtype-richtext/pull/107/files#r1268000236
konradoboza
approved these changes
Jul 20, 2023
alongosz
approved these changes
Jul 20, 2023
Member
alongosz
left a comment
alongosz
left a comment
There was a problem hiding this comment.
+1 for the current state from my side.
tomaszszopinski
approved these changes
Jul 28, 2023
tomaszszopinski
left a comment
tomaszszopinski
left a comment
There was a problem hiding this comment.
QA approved on IbexaDXP commerce 4.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The editor used in 4.x saves tables inside a
<figure>element. The editor would then saveclassanddata-ezattributeon the<figure>element, instead of in the<table>.We did apparently not fix our converters accordingly for 4.x.
I have solved it by making a new XSLT template copies the
classanddata-ezattributeattributes from ancestor element if that is a<figure>element.I have not done anything with docbook->xhtml5.edit transformation. It seems like editor is backward compatible and also deals fine with having missing
<figure>element and the attributes stored on<table>element as before.But maybe we should inject a
<figure>element when sending doc back to editor? Would that be considered a BC maybe ?I think this is a better alternative than solving it in a PHP converter as done in #106
TODO:
$ composer fix-cs).