Skip to content

IBX-6071: Handled custom attributes deselection #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
konradoboza merged 14 commits into from
Jul 21, 2023
Merged

IBX-6071: Handled custom attributes deselection #104

Changes from 11 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3d74c89
IBX-6071: Handled custom attributes deselection
barw4 Jul 11, 2023
e17c345
IBX-6071: CS
barw4 Jul 11, 2023
52fabf6
IBX-6071: CS
barw4 Jul 11, 2023
3d46e31
IBX-6071: Code cleanup
barw4 Jul 11, 2023
fd1ec04
IBX-6071: Code cleanup
barw4 Jul 11, 2023
1361479
IBX-6071: CS
barw4 Jul 11, 2023
6829145
IBX-6071: Applied review remark
barw4 Jul 11, 2023
78baa00
IBX-6071: CS
barw4 Jul 11, 2023
4a9ad18
IBX-6071: Rollbacked solution
barw4 Jul 11, 2023
21aa6c4
IBX-6071: Applied review remarks
barw4 Jul 11, 2023
ab0df3c
IBX-6071: Applied review remark
barw4 Jul 11, 2023
ce4b41b
IBX-6071: Applied review remark
barw4 Jul 12, 2023
ea5908e
IBX-6071: Applied review remark
barw4 Jul 12, 2023
e09fd29
IBX-6071: Fixed problem with selection when default value was empty
barw4 Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/bundle/Resources/public/js/CKEditor/custom-attributes/ui/custom-attributes-form-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,25 @@ class IbexaCustomAttributesFormView extends View {
addListToDropdown(labeledDropdown.fieldView, itemsList);

this.listenTo(labeledDropdown.fieldView, 'execute', (event) => {
const alreadySelectedValues = labeledDropdown.fieldView.element.value ? labeledDropdown.fieldView.element.value.split(' ') : [];
const value = config.multiple ? [...new Set([...alreadySelectedValues, event.source.value])].join(' ') : event.source.value;
const previousValue = labeledDropdown.fieldView.element.value;
let value;

if (config.multiple) {
value = previousValue ? [...new Set([...previousValue.split(','), event.source.value])].join(',') : event.source.value;
} else {
({ value } = event.source);
}

if (previousValue === value) {
if (config.multiple) {
const set = new Set([...previousValue.split(',')]);

set.delete(event.source.value);
value = [...set].join(',');
} else {
value = null;
}
}

labeledDropdown.fieldView.buttonView.set({
label: value,
Expand Down