IBX-6151, IBX-6148: Added check if balloon hasView to prevent trying it add again it, corrected logic for countElementsWithSameId #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it add again it, corrected logic for countElementsWithSameId
|
Kudos, SonarCloud Quality Gate passed!
|
GrabowskiM
approved these changes
Jul 7, 2023
GrabowskiM
requested review from
a team,
Gengar-i,
OstafinL,
dew326 and
tischsoic
and removed request for
a team
Gengar-i
approved these changes
Jul 7, 2023
OstafinL
approved these changes
Jul 7, 2023
dew326
approved these changes
Jul 10, 2023
micszo
approved these changes
Jul 13, 2023
Contributor
micszo
left a comment
micszo
left a comment
There was a problem hiding this comment.
QA Approved on Ibexa Experience 4.5.1-dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
$ composer fix-cs).