[PHPDoc] Improved ContentService doc for API reference #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriendupuis
commented
Jun 7, 2024
adamwojs
approved these changes
Jun 10, 2024
adriendupuis
force-pushed
the
improved_contentservice_phpdoc
branch
from
0700fc8 to
f33c2e7
Compare
adriendupuis
commented
Jun 21, 2024
adriendupuis
commented
Jun 21, 2024
adriendupuis
commented
Jun 21, 2024
adriendupuis
commented
Jun 21, 2024
Member
|
@adriendupuis Could you please address issues reported by phpstan? |
adriendupuis
commented
Jun 24, 2024
adriendupuis
commented
Jun 24, 2024
7 tasks
konradoboza
reviewed
Jun 28, 2024
alongosz
changed the title
Member
|
@adriendupuis this one needs rebase. Are all prior review remarks resolved and is it ready for another round of review? |
adriendupuis
force-pushed
the
improved_contentservice_phpdoc
branch
from
b77b3c9 to
76f9c88
Compare
|
Co-authored-by: Konrad Oboza <[email protected]>
adriendupuis
force-pushed
the
improved_contentservice_phpdoc
branch
from
76f9c88 to
dc5dcff
Compare
konradoboza
approved these changes
Nov 5, 2024
Contributor
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
As long as https://github.com/ibexa/core/pull/379/files#r1828007119 and similar are applied.
Co-authored-by: Konrad Oboza <[email protected]>
|
alongosz
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enhance
ContentServicedoc:ContentService::loadContent)@thows, trailing period, etc.)@see, etc.)PHP API Reference output:
Notice that by inheritance, it also changes the doc for
ContentServiceDecorator:For QA:
Documentation: